Repository navigation
resolve: key local_declaration_scope memo by node id - #571
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
Its own map removes the per-call "local:{id}" format! it used only to
namespace-share lexical_scope_memo; the borrowed get needs no alloc.
73badd6 to
b240fa3
Compare
|
@coderabbitai review |
|
Summary
local_declaration_scopememoized into its ownlocal_decl_scope_memokeyed byn.id— the sharedlexical_scope_memoneeded alocal:-prefixedformat!(a String alloc per call) purely for namespacing; a dedicated map makes the hit path alloc-free.parsed_treekey-interning evaluated and skipped: itsformat!("{}\0{}", lang, path)key would need aBorrowkey wrapper for alloc-freeget— larger complexity than the remaining win justifies.Test plan
build-kernel.mjs --quick)__tests__/kernel-resolve-parity.test.ts— 8/8