Skip to content

explore: batch callerTests' hop 2-3 caller lookups - #574

Merged
bompus merged 1 commit into
fork/consolidatedfrom
perf/caller-tests-batch
Oct 28, 2026
Merged

bompus merged 1 commit into
fork/consolidatedfrom
perf/caller-tests-batch

Conversation

@bompus

@bompus bompus commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • New traverser.getCallersMany(ids) — depth-1 callers for many targets in two round-trips (getIncomingEdgesTo + getNodesByIds), same edge-kind list as getCallersRecursive, deduped per (target, source) pair.
  • callerTests' hop 2–3 expansion now issues one batched query per hop instead of up to 64 getCallers calls; the 64-node budget, visited-set and verdict semantics are unchanged.
  • One ordering caveat: pairs arrive in SQL row order rather than per-frontier-node grouping, so when >2 distinct test files are found the tested via callers note can name a different two. The set of files found is identical; only the display order of an already-arbitrary choice can differ.

Test plan

  • npm run build clean
  • explore-blast-radius + type-hierarchy + full-pipeline: 50 tests

getCallersMany fetches depth-1 callers for a whole frontier in one
incoming-edges query + one getNodesByIds instead of a getCallers
round-trip per node; the same 64-node budget bounds each hop.
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 77c8243 and b913a61.

Files selected for processing: 3
  • src/codegraph.ts
  • src/graph/traversal.ts
  • src/mcp/tools.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bompus

bompus commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@bompus
bompus merged commit a42f5cb into fork/consolidated Oct 28, 2026
4 checks passed
@bompus
bompus deleted the perf/caller-tests-batch branch October 28, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant