Repository navigation
tests: lookup-timeout allowance for the Windows-flaking daemon suites - #575
Merged
Merged
Conversation
Both flaked on Windows CI (unverified vs not-running; a 44s handover timeout): a loaded runner's PowerShell can exceed the 5 s production lookup timeout, and a timed-out probe has no command line to classify. daemon-lock-holder.test.ts already sets 60 s; extend the same env to the two suites that lacked it.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
@coderabbitai review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daemon-registryandmcp-daemonsuites setCODEGRAPH_PROCESS_LOOKUP_TIMEOUT_MS=60000in beforeAll, matchingdaemon-lock-holder.test.ts.Get-CimInstanceexceeds the 5 s production lookup timeout →describeProcessfalls back totasklist(no command line) →classifyLockHolderreturnsunknown→stopDaemonAtreportsunverifiedinstead ofnot-running; handovers wait on the same probes. The env propagates to spawned daemon children.Test plan