Skip to content

support msgpack 1.2.4 - #10551

Merged
ThomasWaldmann merged 1 commit into
borgbackup:masterfrom
ThomasWaldmann:msgpack-124
Oct 26, 2026
Merged

ThomasWaldmann merged 1 commit into
borgbackup:masterfrom
ThomasWaldmann:msgpack-124

Conversation

@ThomasWaldmann

Copy link
Copy Markdown
Member

msgpack 1.2.4 limits container preallocation in the C unpacker to 10000 items, so a large declared array/map length can no longer force an excessive memory allocation (GHSA-j8c6-9vc5-hj6x). max_array_len and max_map_len still limit the total container size.

The other 1.2.4 changes only affect the pure Python fallback unpacker, which borg does not use.

Tested locally (macOS, Python 3.14) with the msgpack 1.2.4 wheel from PyPI: full test suite passes.

🤖 Generated with Claude Code

msgpack 1.2.4 limits container preallocation in the C unpacker to 10000
items, so a large declared array/map length can no longer force an
excessive memory allocation (GHSA-j8c6-9vc5-hj6x). max_array_len and
max_map_len still limit the total container size.

The other changes only affect the pure Python fallback unpacker, which
borg does not use.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.34%. Comparing base (5a78cf4) to head (144a83b).
⚠️ Report is 17 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10551      +/-   ##
==========================================
- Coverage   89.36%   89.34%   -0.03%     
==========================================
  Files         104      104              
  Lines       20082    20091       +9     
  Branches     3152     3154       +2     
==========================================
+ Hits        17947    17950       +3     
- Misses       1478     1484       +6     
  Partials      657      657              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann
ThomasWaldmann merged commit 5f3a5fd into borgbackup:master Oct 26, 2026
25 of 26 checks passed
@ThomasWaldmann
ThomasWaldmann deleted the msgpack-124 branch October 26, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant