Skip to content

support msgpack 1.2.4 (1.4-maint) - #10552

Merged
ThomasWaldmann merged 1 commit into
borgbackup:1.4-maintfrom
ThomasWaldmann:msgpack-124-14
Oct 26, 2026
Merged

ThomasWaldmann merged 1 commit into
borgbackup:1.4-maintfrom
ThomasWaldmann:msgpack-124-14

Conversation

@ThomasWaldmann

Copy link
Copy Markdown
Member

msgpack 1.2.4 limits container preallocation in the C unpacker to 10000 items, so a large declared array/map length can no longer force an excessive memory allocation (GHSA-j8c6-9vc5-hj6x). max_array_len and max_map_len still limit the total container size.

The other 1.2.4 changes only affect the pure Python fallback unpacker, which borg does not use.

Tested locally (macOS, Python 3.14) with the msgpack 1.2.4 wheel from PyPI: full test suite passes.

🤖 Generated with Claude Code

msgpack 1.2.4 limits container preallocation in the C unpacker to 10000
items, so a large declared array/map length can no longer force an
excessive memory allocation (GHSA-j8c6-9vc5-hj6x). max_array_len and
max_map_len still limit the total container size.

The other changes only affect the pure Python fallback unpacker, which
borg does not use.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.09%. Comparing base (9554348) to head (4986aa0).
⚠️ Report is 3 commits behind head on 1.4-maint.

Additional details and impacted files
@@              Coverage Diff              @@
##           1.4-maint   #10552      +/-   ##
=============================================
- Coverage      82.22%   82.09%   -0.14%     
=============================================
  Files             38       38              
  Lines          11480    11480              
  Branches        1808     1808              
=============================================
- Hits            9440     9425      -15     
- Misses          1457     1469      +12     
- Partials         583      586       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann
ThomasWaldmann merged commit cd20fe1 into borgbackup:1.4-maint Oct 26, 2026
14 of 15 checks passed
@ThomasWaldmann
ThomasWaldmann deleted the msgpack-124-14 branch October 26, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant