Repository navigation
Conversation
josbeir
added this pull request to stack #1117
October 18, 2026 08:01
ADmad
reviewed
Oct 18, 2026
markstory
approved these changes
Oct 20, 2026
| * | ||
| * @copyright Copyright (c) Cake Software Foundation, Inc. (https://cakefoundation.org) | ||
| * @link https://cakephp.org CakePHP(tm) Project | ||
| * @since 0.1.0 |
Member
There was a problem hiding this comment.
Suggested change
| * @since 0.1.0 | |
| * @since 4.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1115.
What this adds
Checks freshly generated PHP as part of the existing PHPUnit suite.
The new integration tests bake common classes, complete CRUD stacks, and plugin skeletons, covering attribute routing, legacy routing, and prefixed controllers. Rector only reports required changes; it does not rewrite the generated files. Rector is added as a development dependency so these checks are available in normal test runs.
Template fixes
Fixes the issues these checks found: unused imports, missing type hints, and plugin skeleton formatting. Generated
view(),edit(), anddelete()actions require anint|stringID, supporting numeric IDs and strings such as UUIDs. Expected-output fixtures are updated accordingly.Validation