You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Known optional providers stay discoverable in help connect and help remote, marked plugin, install separately. Calling connect testmu without its plugin gives the exact installation command and instructions to retry the original invocation. JSON distinguishes plugin-not-installed from a selected but unavailable plugin. Unknown names retain their argument error.
agent-device plugins add @agent-device/testmu
Seven files changed. The lightweight provider catalog loads when rendering help or resolving providers, preserving the CLI startup import budget. Replay stays bundled. Refs #3871 (0.22 extraction).
Validation
Head: 9b4e34738599700e0dfbca7f301bc62afafbf7b1.
pnpm check:affected --run --head 9b4e34738599700e0dfbca7f301bc62afafbf7b1: all nine runnable checks passed; receipt run-x6JEvf, exactCommit: true; 888 related tests passed in 85 files.
Startup-budget, CLI help, and plugin-guidance suites: 887 tests passed. The previous Coverage failure at 7bae905913 was the startup-budget assertion (273 eager modules versus 272), before coverage thresholds ran. Help rendering no longer imports the catalog during schema construction.
Original regression proof: base 6ac6611ae7 plus new tests had five failures/one pass; fixed code passed all six. Disposable checkout removed.
Rebuilt help connect retains plugin discovery and installation guidance. Independent follow-up review: no findings.
CI coverage/integration/device results for this head remain pending. No live device behavior changed.
The PR is ready from the code side at 7bae905. The change fits the connect scope in the issue.
Not blocking: the help text hard-codes the "plugin, install separately" marker and the TestMu install line, so it keeps a second copy of what PROVIDER_PLUGIN_CATALOG declares; a catalog-derived marker or a test over every catalog provider would pin it. Also, no test checks that the catalog's testmu provider and @agent-device/testmu package match the plugin's own declaration. Last, in provider-policy.ts, a third-party plugin that claims testmu and fails to load would get a hint to update @agent-device/testmu, so the hint could use the selected entry's package. You can take or leave all three.
I did not run the new tests. The claim that five tests fail on base comes from reading the base code path. I also did not trace non-connect routes for a missing testmu plugin, such as the JS client or opening persisted state, since the issue scopes this PR to connect.
The Coverage job log is cut off while several workers build the macOS helper. That looks like a job timeout, and this diff does not touch that build path, so the failure is likely unrelated. Please re-run Coverage and get it green before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Known optional providers stay discoverable in
help connectandhelp remote, markedplugin, install separately. Callingconnect testmuwithout its plugin gives the exact installation command and instructions to retry the original invocation. JSON distinguishesplugin-not-installedfrom a selected but unavailable plugin. Unknown names retain their argument error.Seven files changed. The lightweight provider catalog loads when rendering help or resolving providers, preserving the CLI startup import budget. Replay stays bundled. Refs #3871 (0.22 extraction).
Validation
9b4e34738599700e0dfbca7f301bc62afafbf7b1.pnpm check:affected --run --head 9b4e34738599700e0dfbca7f301bc62afafbf7b1: all nine runnable checks passed; receiptrun-x6JEvf,exactCommit: true; 888 related tests passed in 85 files.7bae905913was the startup-budget assertion (273 eager modules versus 272), before coverage thresholds ran. Help rendering no longer imports the catalog during schema construction.6ac6611ae7plus new tests had five failures/one pass; fixed code passed all six. Disposable checkout removed.help connectretains plugin discovery and installation guidance. Independent follow-up review: no findings.