Repository navigation
perf(ios): synthesize taps on resolved in-app back controls - #3880
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Review follow-up. isHittable promises a hittable point, not a hittable center, so a bar button partly under an overlay could take a synthesized center tap that misses it. The navigation bar branch keeps XCTest's element tap; the ranked back control, which already tapped its center, keeps the synthesized dispatch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Independent review (Codex, read-only) of P2: the navigation-bar branch replaced Validation at
|
|
This PR is ready at ed1a21f. All 16 checks pass on that commit, and I know of no conflicts. Not blocking, and you can take or leave it: tapResolvedNavigationBackControl in RunnerTests+Navigation.swift repeats the same synthesis-then-XCTest-fallback tap that tapTopLeadingNavigationFallback uses in the same file, so one small private helper that taps a point and reports whether it dispatched could serve both branches. The Bluesky timing ran on 0351d19, not ed1a21f, so one back run on ed1a21f whose runner log shows the coordinateTap synthesis marker would confirm that the ranked branch carries the gain. Nothing else needs to happen before merge. |
|
Summary
Use synthesized coordinate taps for resolved iOS in-app back controls. Retain measured candidate frames through ranking and dispatch to avoid repeated element resolution and XCTest tap quiescence waits. Keep the navigation-bar → ranked back control → verified leading-slot fallback and #2728 typed outcomes. macOS/tvOS behavior is unchanged. Three files; no scope expansion. Related: #2728.
Validation
Base:
642393cadb4510cdccab581c1046ac83e9b52ae8. Head:0351d1996998593599a9a24806298747f2a545c0.pnpm check:affected --run --head 0351d19969: exit 0, exactCommit=true; receipt.tmp/validation/run-YyADUC/receipt.json.pnpm format,pnpm check:xctest-selection, TypeScript build, iOS runner build: passed.CI still owns macOS/native cross-platform builds and integration/coverage. Review control-selection parity and the existing synthesis-failure fallback. No PR was opened by this worker.
Implemented by a Codex worker; opened and reviewed by the coordinating Claude session.
🤖 Generated with Claude Code