[thymikee]

Summary

pnpm clean:xcuitest[:ios|:macos|:tvos|:visionos] ignored AGENT_DEVICE_IOS_RUNNER_DERIVED_PATH and always cleaned the shared ~/.agent-device/apple-runner/derived. A worker that set the override to rebuild its own runner instead removed Build/, Logs/ and the cache json that every other daemon on the host uses.

• The override is now read through resolveRunnerDerivedOverride in apple-runner-platform.ts, which the runner path, cache-retention and unsafe-clean guard also use. The clean script imports it through @agent-device/platform-apple/runner/operations; there is no second env parser.
• The runtime has one override variable and no per-platform ones. With it set, every platform maps to that directory, as in the runner build. The script then removes only transient build entries and keeps other entries, so a mis-set override cannot delete a whole directory.
• With no override, behavior and output are unchanged. Output always names the directory.
• The default layout comes from resolveRunnerScriptDefaultDerivedPath in the runner path owner, which the clean script imports. scripts/build-xcuitest-apple.sh is shell and still spells the same default paths itself; it now trims the override like the runtime, so a blank value means "not set" in both.
• The five clean:xcuitest* scripts and the smoke test run node --experimental-strip-types, because the script imports workspace TypeScript. Without the flag, Node 22.14 fails with ERR_UNKNOWN_FILE_EXTENSION (reproduced); with it the script and all 8 smoke tests pass on Node 22.14.0 and Node 26.
• CONTRIBUTING documents the behavior.

9 files touched.

Validation

Tested head: d3b3d44330 (merged with origin/main). Earlier results below are from f13251f67e.

• New tests in test/integration/smoke-clean-xcuitest-derived.test.ts: override honored for ios and macos with the default directory untouched, and blank override falls back to the default. With the base script, the two override tests fail and the other 6 pass; with this head all 8 pass.
• pnpm test:smoke, vitest run packages/platform-apple/src/runner (958 tests), scripts/__tests__, scripts/layering, test/repo-guards pass.
• typecheck, check:layering, check:di-seams, check:fallow, check:production-exports, check:agent-guidance, check:doc-prose, check:doc-links, check:command-docs, build, check:package, check:bundle-owner-files, format:check exit 0.
• pnpm check:affected --run --head d3b3d44330 exits 1 only at vitest-related: 14 timeouts (5s, 10s, 20s budgets) while the host load average was about 1000. A rerun of the failed files passed all but one provider-scenario file that still timed out under that load. Lint and the other stages passed. CI is the authority for these.
• CI owns coverage, Integration Tests and Apple lanes. No device run applies: no live device behavior changed.
• Manual check used an override under the worktree .tmp/, never the real default directory.

🤖 Generated with Claude Code

[github-actions]

Size Report

Metric	Base	Current	Diff
Installed (including dependencies)	5.53 MB	5.54 MB	+414 B
Package (unpacked)	5.53 MB	5.53 MB	+414 B
Package (download)	1.68 MB	1.68 MB	+102 B

Startup median (7 runs, lower is better):

Scenario	Base	Current	Diff
CLI --version	27.8 ms	27.3 ms	-0.5 ms
CLI --help	53.6 ms	52.5 ms	-1.2 ms

[thymikee]

At f13251f, the clean script breaks on part of the supported Node range. scripts/clean-xcuitest-derived.mjs now imports @agent-device/platform-apple/runner/operations, which resolves to a .ts file. The clean:xcuitest, clean:xcuitest:ios, :macos, :tvos and :visionos scripts in package.json (around line 93) and the smoke test both run plain node, with no --experimental-strip-types. On Node 22.12 to 22.17, which engines allows, I expect the import to fail with ERR_UNKNOWN_FILE_EXTENSION. That would break pnpm clean:xcuitest* and every build:xcuitest:*:clean script, even with no override set. CI runs Node 24.13, so it will not show the break. The other scripts that load workspace TS already pass the flag. Please add it to the five clean:xcuitest* scripts and to the test's spawn args, so the test covers the supported route. Alternatively, keep the script free of TS imports, as it was before this PR. I did not run the script or the smoke test, and I did not try Node 22.12 to 22.17, so this comes from reading the code.

Not blocking, and you can take or leave these: the default layout (DERIVED_ROOT plus macos/tvos/visionos) is still hard-coded in the clean script, in build-xcuitest-apple.sh and in the runtime path code, so only the override is shared. The shell build also reads the override without a trim, so a whitespace-only value counts as set there but not in the clean script or the runtime. The platform !== 'ios' && !DERIVED_OVERRIDE check also appears twice, so one wholeDirectoryClean(platform) helper would be simpler. Could the default base directories be exported from the runner path owner and imported by the clean script? If not, please narrow the PR claim to the override.

The one failing check is the oxlint max-lines rule on packages/platform-apple/src/snapshot-route.test.ts (1003 lines). This PR does not touch that file, and it matches the cap tracked in #3890, so it looks unrelated. Typecheck and format passed. Cubic and Copilot have not reviewed this head, and there are no review threads. No conflicts. Before merge, please add the flag, then land after #3890 is fixed on main.

[thymikee]

Addressed in d3b3d44 (also merged origin/main, so the snapshot-route lint cap is gone).

Blocking: Node 22 .ts import. Fixed by adding --experimental-strip-types to the five clean:xcuitest* scripts and to the smoke test's spawn args, so the test covers the supported route. Verified on a portable Node 22.14.0 (in the worktree .tmp, no global change): without the flag the script fails with ERR_UNKNOWN_FILE_EXTENSION for runner-operations-facade.ts; with it the script runs and all 8 smoke tests pass (also on Node 26). The test also passes --disable-warning=ExperimentalWarning, because Node 22 prints that warning to stderr and it broke the anchored error assertion.

Default layout. Added resolveRunnerScriptDefaultDerivedPath to the runner path owner (runner-cache-metadata.ts, next to RUNNER_DERIVED_ROOT), exported through the operations facade; the clean script imports it instead of building the paths itself. build-xcuitest-apple.sh is POSIX shell and still spells the same default paths, so the PR body now says that. The runtime's keyed cache layout (derived/<base>/cache-<hash>) differs from the script layout, so only the root is shared with it.

Shell trim. The build script now trims the override with sed (whitespace-only counts as unset), matching resolveRunnerDerivedOverride. Checked with blank, padded and empty values.

Duplicate check. One wholeDirectoryClean(platform) helper replaces both copies.

Validation. check:affected --run --head d3b3d44330 exits 1 only at vitest-related: 14 timeouts while the host load average was about 1000. On rerun all but one provider-scenario file passed; that one still timed out. I'll rely on CI for those. PR body updated.

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-22 09:40 UTC

[thymikee]

This PR is ready at d3b3d44. The Node-range break and the duplicated layout in the clean script from the earlier review are both fixed, and CI is green (23 checks, none failing). The change touches only the clean script, its smoke test and the package.json scripts, so no daemon or device route is involved. I read the head files but did not check out the branch or run the smoke tests, and I did not run the clean script on Node 22.12-22.17 myself (you report runs on 22.14.0 and 26). Nothing else must happen before merge. Not blocking, take or leave: the Node-22 flag lives only in the package.json script strings, so reverting them would keep the smoke tests green, and one assertion in test/repo-guards/npm-package-scripts.test.ts that every clean:xcuitest* script starts with node --experimental-strip-types scripts/clean-xcuitest-derived.mjs would guard it; also the default derived layout is still spelled in both resolveRunnerScriptDefaultDerivedPath and resolve_default_derived_path in scripts/build-xcuitest-apple.sh, and the shell could ask the TS owner for the path as it already does for build settings, or at least runner-cache-metadata.ts could hoist its repeated "derived" base into one const.