Repository navigation
perf: expect the persistent session on Android snapshot-raw - #3913
Merged
Merged
Conversation
Fail the heavy-feed snapshot-raw step with expectation_failed when the persistent helper session did not answer, so one-shot timings stay out of the session baseline. Drop the redundant second sessionCapture assignment in the helper capture flow. Follow-up to #3902. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
This is ready at a9564b0. I found no problems in the code, all 16 checks are green, and there are no conflicts. Not blocking, take or leave: |
thymikee
added
the
ready-for-human
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the two non-blocking notes left on #3902 (4 files, no capture behavior change):
heavy-feed/snapshot-rawon Android now expects thepersistent-sessiontransport. A night where the helper session stays off fails that step asexpectation_failedinstead of mixing one-shot timings into the baseline. The step keeps its depth expectation. The README states the contract.captureAndroidUiHierarchyFromHelperno longer assignssessionCapturetwice. The timer callback assignment stays, because the data thunk reads it when the timer settles. The recordedtransportandansweredfields are unchanged.Follow-up to #3902.
Validation
Tested at the head SHA.
vitest run scripts/perf: 46/46 passed. The new suite test fails when thesuite.tschange is reverted.vitest run packages/platform-android/src/__tests__/snapshot: 22 files, 190 tests passed, includingsnapshot-helper-capture-timers.test.ts.pnpm typecheck,pnpm format: clean.pnpm check:affected --run --head <head>: passed,exactCommit: true. The first run hit an unrelatedENOTEMPTYtemp-dir cleanup race indaemon-client-abort.test.ts. That file passes alone, and the re-run passed.🤖 Generated with Claude Code