Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The vanilla RN demo and the Expo demos duplicate runtime code, and some runtime helpers are currently bundled from a test package. Move the shared code into the private
@callstack/shared-runtimeworkspace and rename the test-only workspace to@callstack/shared-tests.apps/AndroidApp.Most file changes are moves and removal of duplicate files. Published packages and generated native bindings are unchanged; no package release is needed.
Validation
yarn test:apps: 36 tests passed across vanilla RN, Expo 57, Expo 58 and shared Node tests.yarn test:scripts: 18 tests passed.yarn lint,yarn typecheck,yarn build: passed.tsc --noEmit: passed after navigation codegen/build; generated bindings were restored afterwards.Native iOS host E2E
All 11 Detox tests passed with the JavaScript bundle embedded in the native
AppleApphost (no Metro):Local environment: Xcode 26.3 / Swift 6.2.4, iOS 26.1 simulator. The Expo simulator apps and their embedded frameworks were signed ad hoc after the build (
CODE_SIGNING_ALLOWED=NOotherwise left ExpoFont unsigned). Expo 58 also required a temporary local compatibility workaround inexpo-modules-jsi@58.0.4for the upstream Swift 6.2 constructor-annotation and pointer-capture errors (Expo issue #50067, upstream fix #51040). Dependency originals were restored afterwards; no workaround or generated native files are included in the PR. The unmodified Expo 58 iOS build remains unverified on a compatible Xcode toolchain.The earlier standalone RNApp attempt reported a missing
BrownfieldStore(also reproduced with the original counter). The actual native host initializes that store, and its counter E2E passes. Native Android E2E was not run.