Repository navigation
feat: modernize RadioButton for MD3 #5007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
6221077
a155b74
015baf4
9649647
9e4a668
d9f3973
ee00e84
c0e1c18
e486e99
2b4eebb
1d1ea02
3c226a1
ea2a6e9
a1a3e75
feb9a54
5554631
12644a8
e0366bc
4008f1a
12e10e1
1fc4903
98786fd
af9cb8c
4bb43cd
ec36997
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,23 +107,13 @@ export const screenshots = { | |
| Modal: 'screenshots/modal.gif', | ||
| ProgressBar: 'screenshots/progress-bar.png', | ||
| RadioButton: { | ||
| 'Android (enabled)': 'screenshots/radio-enabled.android.png', | ||
| 'Android (disabled)': 'screenshots/radio-disabled.android.png', | ||
| 'iOS (enabled)': 'screenshots/radio-enabled.ios.png', | ||
| 'iOS (disabled)': 'screenshots/radio-disabled.ios.png', | ||
| }, | ||
| 'RadioButton.Android': { | ||
| enabled: 'screenshots/radio-enabled.android.png', | ||
| disabled: 'screenshots/radio-disabled.android.png', | ||
| }, | ||
| 'RadioButton.Group': { | ||
| Android: 'screenshots/radio-button-group-android.gif', | ||
| iOS: 'screenshots/radio-button-group-ios.gif', | ||
| }, | ||
| 'RadioButton.IOS': { | ||
| enabled: 'screenshots/radio-enabled.ios.png', | ||
| disabled: 'screenshots/radio-disabled.ios.png', | ||
| }, | ||
| 'RadioButton.Item': 'screenshots/radio-item.ios.png', | ||
|
Comment on lines
114
to
117
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| Searchbar: { | ||
| bar: 'screenshots/searchbar.png', | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v5
RadioButton.Androidis 36dp (a 20dp ring with an 8dp margin) andRadioButton.IOSis 36dp (a 24dp icon with 6dp padding). The box grows by 12dp, not 8dp, and aRadioButton.Itemrow goes from 52dp to 64dp. ThehitSlopsentence describes an earlier revision of this PR. v5 never addedhitSlop, so it gives readers nothing to compare with.(via Claude, verify if it makes sense)