Repository navigation
chore: enforce the 10-day release age with pnpm 11 - #89
Merged
Merged
Conversation
pnpm 11 no longer reads minimumReleaseAge from .npmrc: pnpm config get minimumReleaseAge returned undefined, so new dependency versions were not held back. The setting now lives in pnpm-workspace.yaml, in minutes (14400 is 10 days), next to the existing exclusion list, the same way cf-services sets it. pnpm config now reports 14400, a frozen install still passes, and pnpm refuses a version that is less than 10 days old.
 [Medium impact] This PR appears safe to merge. SummaryMoves the intended ten-day dependency release delay into
Reviews (1) · Last reviewed commit: "chore: enforce the 10-day release age wi..." · Reviewed by Greptile |
|
Docs7 for cardmagic/solid-objects-js
Commit |
The vite advisory fix (#88) ran pnpm add while pnpm ignored the release age, so the lockfile took rolldown 1.2.15, postcss 8.5.31, and @oxc-project/types 0.155.0, published one to three days earlier. With the release age on, a frozen install rejects these 18 entries. The lockfile now starts again from the one before #88 and resolves vite ^8.3.4 under the release age: vite 8.3.4, rolldown 1.2.13, and postcss 8.5.29. A frozen install, pnpm audit at the high level, pnpm test, and test:cloudflare pass.
Owner
Author
|
CI failed on the frozen install after the branch update: the release age rejected 18 lockfile entries that #88 added while the guard was off (rolldown 1.2.15, postcss 8.5.31, @oxc-project/types 0.155.0). The new commit resolves vite ^8.3.4 again under the release age (vite 8.3.4, rolldown 1.2.13, postcss 8.5.29). A frozen install, the high-level audit, pnpm test, and test:cloudflare pass locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minimumReleaseAgefrom.npmrc.pnpm config get minimumReleaseAgereturnedundefined, so the 10-day hold on new dependency versions was off.pnpm-workspace.yamlasminimumReleaseAge: 14400(minutes, 10 days), next to the existingminimumReleaseAgeExcludelist. cf-services sets it the same way..npmrcline is removed.Checks
pnpm config get minimumReleaseAgereports14400.pnpm install --frozen-lockfilepasses with the current lockfile.pnpm add -D vite@8.3.5now fails withERR_PNPM_NO_MATURE_MATCHING_VERSION, because that release is one day old.