Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five
Luaxmacros (luax--def-maybe-getand the global and field setters and getters) defined their functions by callingevalon a(do (doc …) (defn …))form at expansion time. Each was the macro's last expression, so the macros now return that form instead, and the compiler defines the functions as it would any other expansion. Usage is unchanged. TheevalinLua.setupstays: it runssystem-includeandadd-cflag, not definitions.The reason is portability, as in suite#3 and web#73: a compiler that expands macros ahead of time and keeps compile-time code apart from the program can't
evala static definition in the middle of expansion. metacarp is one, andluafailed there because its compile-time evaluator has nometa-set!, whichdocneeds. With this change the library compiles on metacarp.Tests. On the reference compiler all five test files pass (76, 86, 10, 22 and 25 tests), as do lint, format and gendocs. On metacarp the main suite passes, 76/76.