Repository navigation
ENT-14731: Unit tests and syntax validation for cf-reactor - #6416
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
victormlg
force-pushed
the
cf-reactor.SyntaxCheck
branch
from
October 16, 2026 13:14
b9e9130 to
d9e7491
Compare
- Moved file_deleted event type test to file_watcher_test - Added test coverage for watcher Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor.SyntaxCheck
branch
from
October 19, 2026 12:29
d9e7491 to
acbb3a0
Compare
larsewi
approved these changes
Oct 20, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀 Next time, split pure moves and adds to separate commits. It makes it much easier to review.
Contributor
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14828/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14828/ |
larsewi
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.