Skip to content

fix(quake): incorporate public-key overrides into genesis cache key (… - #500

Closed
janmd07 wants to merge 1 commit into
circlefin:mainfrom
janmd07:fix/quake-genesis-cache-override-keys
Closed

janmd07 wants to merge 1 commit into
circlefin:mainfrom
janmd07:fix/quake-genesis-cache-override-keys

Conversation

@janmd07

@janmd07 janmd07 commented Oct 30, 2026

Copy link
Copy Markdown

Summary

Fixes #499

This PR fixes a genesis cache collision caused by public-key override mappings being excluded from the cache metadata.

Details

  • Adds a canonical metadata helper for genesis cache keys.
  • Sorts public-key overrides by validator index before hashing.
  • Includes a Keccak-256 digest of the override mappings in the cache metadata.
  • Preserves the existing cache metadata format when no overrides are configured.
  • Adds regression tests to verify cache isolation across different override mappings.

Testing

  • cargo clippy -p quake -- -D warnings
  • cargo test -p quake --bin quake setup::tests -- --nocapture
  • cargo test -p quake --bin quake -- --nocapture
  • rustfmt --check crates/quake/src/setup.rs
  • git diff --check
  • Targeted Hardhat genesis-generation E2E verification

All reported checks passed.

Fixes #499

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Unsigned Commits Detected

The following commits are missing a verified signature:

  • d914dca by janmd07

How to fix: Sign your commits.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @janmd07,

Thank you for your interest in contributing to Arc Node.

This PR has been automatically closed because you are not assigned to issue #499. We require contributors to be explicitly assigned to an issue before submitting a PR.

To contribute properly:

  1. Comment on issue bug(quake): genesis cache metadata ignores public-key override mappings #499 requesting assignment
  2. Wait for maintainer approval
  3. Only submit a PR after you have been assigned

Please see our CONTRIBUTING.md for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(quake): genesis cache metadata ignores public-key override mappings

1 participant