Skip to content

enhancement/LCHIB-614: utilize surefire report extended by rerunFailingTests feature - #1404

Merged
jothikumar-CB merged 4 commits into
v1from
enhancement/LCHIB-614-utilize-surefire-report-extended-by-rerun-feature
Oct 22, 2026
Merged

jothikumar-CB merged 4 commits into
v1from
enhancement/LCHIB-614-utilize-surefire-report-extended-by-rerun-feature

Conversation

@jothikumar-CB

@jothikumar-CB jothikumar-CB commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor
  • Maven Surefire's rerunFailingTestsCount feature records retried tests using / (passed eventually) or / (failed every attempt) child elements inside a single . The CLI's JUnit parser (junitparser's TestCase.ITER_TYPES) never recognized these Surefire-specific tags, so flaky tests silently reported as plain PASS and only the first of several failed rerun attempts was ever recorded — losing both the flaky signal and every other attempt's failure log.
  • CaseEvent.from_case_and_suite (launchable/commands/record/case_event.py) now expands one into multiple case events when these tags are present: N FAILED + 1 final PASSED for flaky tests, 1+N FAILED (no PASSED) for tests that fail on every rerun. Only the first emitted event keeps the real duration; the rest get 0, so total test time isn't double-counted.
  • tests.py's call site changed from yield to yield from to flatten the (now list-returning) results-event stream — no other code in the pipeline needed to change.
  • Reports without any of these four tags produce byte-identical test case events like before making this change.

@jothikumar-CB jothikumar-CB self-assigned this Oct 19, 2026
@jothikumar-CB jothikumar-CB added the Smart Tests CLI The next gen CLI label Oct 19, 2026
@jothikumar-CB
jothikumar-CB changed the base branch from main to v1 October 19, 2026 11:30

@Konboi Konboi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread launchable/commands/record/case_event.py
Comment thread tests/data/maven/reports-flaky/TEST-flaky.xml
@jothikumar-CB
jothikumar-CB requested a review from Konboi October 21, 2026 10:01
Comment thread tests/test_runners/test_maven.py Outdated
@jothikumar-CB
jothikumar-CB merged commit 5092d6e into v1 Oct 22, 2026
14 checks passed
@jothikumar-CB
jothikumar-CB deleted the enhancement/LCHIB-614-utilize-surefire-report-extended-by-rerun-feature branch October 22, 2026 08:26
@github-actions github-actions Bot mentioned this pull request Oct 22, 2026
@github-actions github-actions Bot mentioned this pull request Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Smart Tests CLI The next gen CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants