Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
ono-max
reviewed
Oct 21, 2026
| '--session', | ||
| 'session', | ||
| help='In the format builds/<build-name>/test_sessions/<test-session-id>', | ||
| type=str, |
Contributor
There was a problem hiding this comment.
How about making this option required?
Suggested change
| type=str, | |
| type=str, | |
| required=True |
Contributor
Author
There was a problem hiding this comment.
I'll make it required when merging to main. Since this PR is created for the v1 branch, I guess I could keep it as it is?
ono-max
approved these changes
Oct 21, 2026
ono-max
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new command:
This should be merged after #14529