Repository navigation
Fix undefined array key “id” warning in filter_image_block_render_block - #1321
Merged
Merged
Conversation
filter_image_block_render_block reads $block[‘attrs’][‘id’] whenever a core/image block has overwrite_transformations set. If the block has no id attribute, for example an image block that points at a URL rather than a media library image, PHP logs “Undefined array key id” on every render. This adds a check that the id is not empty before the str_replace runs. Blocks with an id behave as before. QA notes Add a core/image block that uses an external image URL and has overwrite_transformations set in its attributes, and view the page on PHP 8.2 or later with WP_DEBUG on. Before the change, the warning appears in the log for class-filter.php line 733. After the change, it does not. Confirm an image block from the media library with overwrite transformations still gets the cld-overwrite class.
Collaborator
|
@robertgray-topflight thank you for your contribution! This will be included in the upcoming release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach
filter_image_block_render_blockreads$block['attrs']['id']whenever acore/imageblock hasoverwrite_transformationsset. If the block has noidattribute, for example an image block that points at a URL rather than a media library image, PHP logs "Undefined array key id" on every render. This adds a check that the id is not empty before thestr_replaceruns. Blocks with an id behave as before.QA notes
core/imageblock that uses an external image URL and hasoverwrite_transformationsset in its attributes, then view the page on PHP 8.2 or later withWP_DEBUGon.class-filter.phpline 733. After the change, it does not.cld-overwriteclass.