Repository navigation
Fixes #2: Add Error Prone, NullAway and JSpecify - #3
Merged
Merged
Conversation
- Run Error Prone and NullAway (as an Error Prone check) on compilation. - Mark all packages as JSpecify @NullMarked, so NullAway checks just the project code (dependencies are seen as unannotated). - Fix the issues the tools found. - Build on JDK 21 in CI, since Error Prone requires it (bytecode still targets Java 17). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Changes
maven-compiler-pluginruns Error Prone 2.50.0 with NullAway 0.14.2 atERRORlevel..mvn/jvm.configadds the JDK options Error Prone needs.StringConcatToTextBlockis disabled because it crashes on some code.package-info.javawith@NullMarked, and NullAway runs withOnlyNullMarked=true. This way only this project's code is checked; CloudSim Plus classes (some share package names, such asorg.cloudsimplus.testbedsandorg.cloudsimplus.heuristics) are seen as unannotated.<release>17</release>is kept, so the generated bytecode doesn't change.@Nullablewhere null is valid, and@SuppressWarnings("NullAway.Init")for fields set after construction (with a comment saying where).Bugs and other changes from the tools
CloudletToVmMappingSolutionBenchmark.doSetup()heuristicfield, so the field stayednulland was passed toCloudletToVmMappingSolution.Tests
mvn -B packagepasses locally on JDK 21 and 25.Related: cloudsimplus/cloudsimplus#570
🤖 Generated with Claude Code