Repository navigation
Conversation
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
✅ Deploy Preview for cncf-techdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
iRaindrop
left a comment
There was a problem hiding this comment.
Reviewed the harness against the KubeVirt .github folder it was copied from. The structure copied cleanly (all content diffs are Prettier line-wrapping). The comments below cover what is still KubeVirt-specific and what would make the harness complete end-to-end for the next project.
Suggestions not tied to a specific line:
- Add a
/rank-recommendationsprompt that producesinput/ai-ranked-recommendations.csv. For KubeVirt this ranking step was ad hoc; codifying it closes the only manual gap in the pipeline. - Reference (or add) the upload process. The issue prompts say "a process will upload" the files, but the harness does not say where that script or workflow lives.
- Record the validated toolchain in
ai-harness.md: Copilot CLI version, model, and that the prompt files rely onmode: agentand${input:title}. - Add a pre-flight checklist: required labels exist in the target repo (
help wanted, the three priority labels), the project'sanalysis.mdis scaffolded from the techdocs template, and.githubhas no conflicting prompt files. - Consider an
examples/kubevirt/folder holding the KubeVirt "Current Repository" section and issue template, so the generic files stay generic but a worked example is still available.
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
iRaindrop
left a comment
There was a problem hiding this comment.
Second pass over the harness at a834e7d. All earlier threads are addressed, CI is green, and the structure is consistent end to end (criteria → wrappers → engines → issue prompts → upload process). The remaining edits are small; only the first one affects a data contract (the CSV Section value), the rest are wording and clarity. None block the merge; they can land in a follow-up if preferred.
- Align section and area display names with the copilot-instructions tables (Website & Infrastructure; Information Architecture; SEO, Analytics, and Site Search; Usability, Accessibility and Devices) - Fix typo (Precede) in comment engine - Tell section-comment engine how to fill the Other Metrics table - Move the umbrella template example into the HTML comment - Clarify per-answer paragraph length in answers engine - Drop stray period in index.md toolchain list - Sync the KubeVirt example's No commits wording with the template Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
|
Ready to merge Note: This commit fixes a link issue from 404s in older Analyses files, currently preventing the other open PRs from merging: |
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
chalin
left a comment
There was a problem hiding this comment.
@iRaindrop @nate-double-u - Why hide the template files under _github from the site deploy?
kmkhz
left a comment
There was a problem hiding this comment.
Hi Bruce,
I think I only got about an inch deep with this review, but it's long. So I'll submit it now and take a fresh look on Monday.
Thanks,
Kristen
| the umbrella's sub-issue list resolves. | ||
|
|
||
| For KubeVirt this was done with a `gh issue create` script run by the writer; | ||
| the script is not part of the harness yet. Until it is added here, write the |
There was a problem hiding this comment.
the script is not part of the harness yet. Until it is added here
What prevented this script from being added to the harness? What are the next steps here?
There was a problem hiding this comment.
Issue workflow details tbd
| `.github/templates/umbrella-issue.md` template: an `## Umbrella Issue` | ||
| overview and a `## Sub-issues` list that links to the sub-issue files. The | ||
| umbrella does not contain the sub-issue content. | ||
| - Copilot is at liberty to create subheadings in the issue files as needed to |
There was a problem hiding this comment.
Do we want to limit the heading level depth? I'd recommend 4 or fewer levels of heading.
There was a problem hiding this comment.
Removed that bullet - not needed
| - Set `repo` to the issues repository URL from the "Current Repository" | ||
| section. | ||
|
|
||
| ```yaml |
There was a problem hiding this comment.
The .github/output/issues/ MD file acts as both a staging artifact and a final payload for issue creation, which conflates local workflow metadata with the final issue payload schema. I think we need to define the issue creation workflow better to resolve this.
Co-authored-by: Kristen K <kmkelle.mail@gmail.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Co-authored-by: Kristen K <kmkelle.mail@gmail.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Co-authored-by: Kristen K <kmkelle.mail@gmail.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Co-authored-by: Kristen K <kmkelle.mail@gmail.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Co-authored-by: Kristen K <kmkelle.mail@gmail.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Co-authored-by: Kristen K <kmkelle.mail@gmail.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Co-authored-by: Kristen K <kmkelle.mail@gmail.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Provides the directory structure and guidance under
.githubin the project's doc website repo for conducting an AI-assisted analysis using Copilot GitHub Enterprise.