Skip to content

ci(tweak): centralize node version - #5770

Open
kobenguyent wants to merge 13 commits into
4.xfrom
centralized-node-version
Open

kobenguyent wants to merge 13 commits into
4.xfrom
centralized-node-version

Conversation

@kobenguyent

@kobenguyent kobenguyent commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation/Description of the PR

Summary of Changes

✅ Restored Node.js version testing strategy:

  • test.yml: Kept explicit [22.x, 26.x] matrix for the main unit-tests job to test both LTS and latest versions
  • Windows and runner jobs use [22.x] matrix (as needed for platform-specific testing)

✅ Simplified all other workflows:

  • 13 workflows now use GitHub's built-in node-version-file: '.nvmrc' parameter
  • Removed custom "Read .nvmrc" step (cleaner, official approach)
  • Removed unnecessary strategy.matrix entries for single-version workflows
  • Appium workflows kept their test-suite matrix while using .nvmrc

✅ Benefits:

  • Single source of truth (.nvmrc) for default Node version
  • Test.yml still validates against both
    22.x and 26.x
  • Other workflows auto-read from .nvmrc without extra steps
  • Cleaner, less repetitive YAML

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
kobenguyent requested a review from DavertMik October 26, 2026 15:32
@DenysKuchma

Copy link
Copy Markdown
Collaborator

Hi, @kobenguyent
Nice idea, but this drops the Node 26 matrix job, we'd stop testing the newest Node. Also setup-node can read the file directly (node-version-file: '.nvmrc'), no extra step needed. Could you keep an explicit [22.x, 26.x] matrix where we test multiple versions and use node-version-file for the rest?

@kobenguyent

Copy link
Copy Markdown
Collaborator Author

Hi, @kobenguyent Nice idea, but this drops the Node 26 matrix job, we'd stop testing the newest Node. Also setup-node can read the file directly (node-version-file: '.nvmrc'), no extra step needed. Could you keep an explicit [22.x, 26.x] matrix where we test multiple versions and use node-version-file for the rest?

thanks @DenysKuchma for reviewing, updated as suggested.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants