Skip to content

fix: copy ctx.params to avoid mutating shared dict in get_cli_args - #808

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/copy-cli-args-dict
Open

sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/copy-cli-args-dict

Conversation

@sentry

@sentry sentry Bot commented Oct 18, 2026

Copy link
Copy Markdown

In main.py, ctx.obj["cli_args"] = ctx.params was aliasing the dictionary instead of copying it. Subcommand calls to get_cli_args mutate ctx.obj["cli_args"] directly via args.update(...) and del args["token"], mutating the shared dictionary across subcommands and causing unexpected state such as KeyError: 'token'. Using dict(ctx.params) decouples cli_args from the parent context parameters.

Fixes CLI-HY

@sentry <feedback>: Autofix iterates on these changes
@sentry stop iterating: Autofix stops iterating on this run

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
723 1 722 1
View the full list of 1 ❄️ flaky test(s)
api.temp.calculator.test_calculator::test_divide

Flake rate in main: 100.00% (Passed 0 times, Failed 1726 times)

Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants