Repository navigation
Restyle lobbying beta banner as a slim one-line bar - #2304
Merged
Merged
Conversation
mvictor55
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
nesanders,
sashamaryl and
timblais
as code owners
October 21, 2026 18:59
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Mephistic
approved these changes
Oct 22, 2026
Mephistic
left a comment
Mephistic
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - the new banner is much less intrusive.
We should probably prefer to either use styled-components (or switch back to CSS Modules) rather than dropping these styles in pure objects... but the trade-offs for that don't really matter for this component, so I'm fine merging this now and filing that under "problem for the React 19 upgrade" so we can get this out now.
Heads up - it looks like the screenshots in the PR description didn't quite make it in - only the filenames are there.
dasanchez
added a commit
to hyphacoop/maple
that referenced
this pull request
Oct 26, 2026
Brings in upstream's lobbying changes: filings record their reporting period (codeforboston#2308), the scraper image deploys on pushes to main and prod (codeforboston#2309), and the slimmer beta banner (codeforboston#2304). Both branches wrote a period on filings from the same parsed disclosure. Upstream's write_filings and LobbyingFiling type, which record periodStart as well as periodEnd, replace this branch's periodEnd-only version. The ingestion doc keeps both the new deploy workflow and the ARCHIVE_DIR check, lists periodStart on filings, and adds the filing-periods phase to the backfill as a check: after the write phase it should find nothing to update. Verified: python -m pytest -q in lobbying-scraper and pytest lobbying-scraper/tests from the root (183 passed each); tsc --noEmit (only the 4 local typesense errors); jest components/lobbying; prettier on docs and functions/src/lobbying. On the full local scrape in the emulator, filing-periods --execute updated 592,145 filings with no conflicts, and a second dry run found none to update. Not verified: the new deploy workflow on this branch's changes; the filing-periods check against dev or prod. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
29 tasks
dasanchez
added a commit
to hyphacoop/maple
that referenced
this pull request
Oct 26, 2026
Brings in fix/88's merge of upstream main: filings record their reporting period (codeforboston#2308), the scraper deploy workflow (codeforboston#2309) and the slimmer beta banner (codeforboston#2304). The redesigned Bill and Client pages stay as they are: upstream's period sort changed the old filings tables they replaced. The Lobbyist page takes upstream's period sort, and its filings table labels rows by period. The Lobbying Explorer uses upstream's slim beta banner in place of the redesign's. Verified: tsc --noEmit (only the 4 local typesense errors), jest components/lobbying (70 passed), next lint, prettier --check. In the browser on the local scrape: the slim banner; Jackie McCarthy's Lobbyist page labeling rows "Jan–Jun 2026"; the H4746 Bill page loading its organizations; no page errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restyles the Lobbying Explorer's beta banner. It was three lines of large text that pushed the page down; it is now a slim, single-line orange bar with a small "BETA" tag and a shorter message: "The lobbying explorer is in beta. Send feedback to info@mapletestimony.org".
components/lobbying/LobbyingSubnav.tsx). The sharedBannercomponent used on bill, profile and conference committee pages is untouched.public/locales/en/lobbying.jsonare replaced (betaLine1/betaLine2→beta/feedback); nothing else used the old keys.Checklist
firestore.indexes.json. (N/A: no queries)Screenshots
lobbying-before-desktop.png
lobbying-after-desktop.png
lobbying-before-phone.png
lobbying-after-phone.png
Known issues
i18next/no-literal-stringlint warning, unchanged).Steps to test/reproduce
/lobbyingon the preview deployment./lobbying/bills,/lobbying/clientsand/lobbying/firmsand confirm the same bar appears.