Repository navigation
Conversation
bompus
marked this pull request as ready for review
September 11, 2026 04:58
10 tasks
bompus
force-pushed
the
fix/upstream-cli-stale-sync
branch
from
September 15, 2026 15:00
cb8dbdc to
d3a8cc3
Compare
A quiet sync is the git-hook path. The stale-index refusal still exits 1, but now writes one line to stderr so a hook that fails the commit on a non-zero exit does not block it for an invisible reason. (colbymchenry#1798)
bompus
force-pushed
the
fix/upstream-cli-stale-sync
branch
from
September 16, 2026 13:26
d3a8cc3 to
8ac04d4
Compare
inth3shadows
added a commit
to inth3shadows/codegraph
that referenced
this pull request
Sep 26, 2026
…nc @ 8ac04d4) # Conflicts: # CHANGELOG.md
inth3shadows
added a commit
to inth3shadows/codegraph
that referenced
this pull request
Sep 26, 2026
colbymchenry#1842's quiet-sync test skips the relaunch (CODEGRAPH_WASM_RELAUNCHED=1) that adds --disable-warning=ExperimentalWarning. With colbymchenry#1913 merged the directory probe loads node:sqlite on that path, so the SQLite warning reached stderr and broke the one-line assertion. Pass the same flags.
This was referenced Sep 26, 2026
inth3shadows
added a commit
to inth3shadows/codegraph
that referenced
this pull request
Sep 29, 2026
colbymchenry#1842's quiet-sync test skips the relaunch (CODEGRAPH_WASM_RELAUNCHED=1) that adds --disable-warning=ExperimentalWarning. With colbymchenry#1913 merged the directory probe loads node:sqlite on that path, so the SQLite warning reached stderr and broke the one-line assertion. Pass the same flags.
inth3shadows
added a commit
to inth3shadows/codegraph
that referenced
this pull request
Sep 29, 2026
Tree = upstream main + the open PRs that still merge cleanly: colbymchenry#1925, colbymchenry#1957, colbymchenry#1962, colbymchenry#1955, colbymchenry#1965 and the current heads of colbymchenry#1842 and colbymchenry#1913. Upstream has already carried colbymchenry#1969-colbymchenry#1971, colbymchenry#1082 and colbymchenry#1791. Dropped until they are rebased onto upstream's resolver rewrite: colbymchenry#1704, colbymchenry#1921, colbymchenry#1926 and colbymchenry#1935.
inth3shadows
added a commit
to inth3shadows/codegraph
that referenced
this pull request
Oct 15, 2026
colbymchenry#1842's quiet-sync test skips the relaunch (CODEGRAPH_WASM_RELAUNCHED=1) that adds --disable-warning=ExperimentalWarning. With colbymchenry#1913 merged the directory probe loads node:sqlite on that path, so the SQLite warning reached stderr and broke the one-line assertion. Pass the same flags. (cherry picked from commit 77e16eb)
inth3shadows
added a commit
to inth3shadows/codegraph
that referenced
this pull request
Oct 21, 2026
Upstream merged 17 of the fork's carried PRs on 2026-10-20 (several squashed, some with maintainer edits; colbymchenry#1704's content landed inside colbymchenry#1926). Every conflict was our pre-merge copy of one of them, so the upstream side was taken throughout. After the merge the tree differs from upstream only by colbymchenry#1842, its test-flag fix, .gitignore, the untracked .pyc and the README banner. Dropped __tests__/sync-synthesis-input-package.test.ts: colbymchenry#2574 was superseded by upstream colbymchenry#2688, which does not normalize spellings like `@/widgets/Chart/`. That gap is colbymchenry#2577; it is carried separately via colbymchenry#2610.
inth3shadows
added a commit
to inth3shadows/codegraph
that referenced
this pull request
Oct 25, 2026
Fork fixes colbymchenry#2588, colbymchenry#2766, colbymchenry#2807 superseded/merged upstream (maintainer colbymchenry#2802, colbymchenry#2811, colbymchenry#2802). Removed from fork README carried-fixes list. Fork-only items retained: - sync stale-index check (colbymchenry#1842) - sync-synthesis-input-package test - ts-outer-declared-receiver test - cli-sync-stale-index test
colbymchenry
pushed a commit
that referenced
this pull request
Oct 31, 2026
An index built by an older extraction version made `codegraph sync` print "Already up to date" while `codegraph status` said to re-index. Sync re-reads changed files only and never advances the extraction stamp, so that message was false however little had changed. Sync now says "No files changed" in that case and ends with a warning that names `codegraph index`, after syncing changed files as before. It exits 0. Refusing, as the PR first did, would have stopped the installed git hooks: they run sync in the background with its output discarded, so every index behind a hook would quietly stop following commits on the next upgrade. `--quiet` stays silent, as cli-sync.test.ts already pins. Validation: the new cli-sync-stale-index.test.ts has 6 cases for an old stamp and a missing one, unchanged and changed files, quiet and not, a current index, and the rebuild clearing the warning. 3 fail on main, 6 pass here. A real commit through the installed post-commit hook on a stale index put the new file in the index in about a second. Original PR #1842 by @bompus. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks @bompus! This landed as #3121 with your authorship. One change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An index built with an older extraction version can make
codegraph syncprint “Already up to date” and exit 0 even thoughstatusrecommends a rebuild. With source edits, sync updates only those files and still leaves the index stale.The CLI now checks the existing extraction-staleness signal before incremental work, closes the graph, and exits 1 with a
codegraph indexrecovery instruction.--quietalso exits 1 and prints the reason as a single stderr line, so a git hook that fails on a non-zero exit still shows the user why. Current indexes continue syncing normally; a full index restores successful sync. The guard is confined to the explicit CLI command, preserving library and watcher incremental behavior.Related to #1798: this addresses the misleading CLI success signal, not the proposed automatic background rebuild. It complements #1256's status/upgrade guidance changes.
Validation on Node 24.21.0, Linux/WSL2, based on upstream
3ed73bc:The equivalent fork integration also passed full native (4,742) and WASM (4,740) suites and five deployment probes. Those full-suite results are from the consolidated fork; the focused tests above were rerun on this upstream-only branch. Windows and the viewer build were not rerun for this change.