Repository navigation
Conversation
…colbymchenry#2503) `ChargeCard.call` records a references edge from the caller to the class, but `Billing::ChargeCard.call` did not: only a bare `constant` receiver got one, so a class used only through namespaced class-method calls looked like it had no dependents. A `scope_resolution` receiver whose last segment is capitalized now emits a references ref too, under its qualified name with a leading `::` dropped. The resolver already maps that to the right class, so `Users::Create.call` reaches `Users::Create` rather than a `Billing::Create`, and `Deep::Op.call` written inside `module Svc` reaches `Svc::Deep::Op`. The native kernel (ruby.rs) makes the same change, so both backends emit identical refs, `::Foo.call` included.
# Conflicts: # CHANGELOG.md
Owner
|
Thank you for the PR and its five-case test, @drakeo338! The same fix landed on main as #2827: a namespaced receiver like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2503.
Problem
Billing::ChargeCard.callrecorded noreferencesedge toBilling::ChargeCard, so a class used only through namespaced class-method calls had no callers. Only a bareconstantreceiver got one (#1110).Fix
A
scope_resolutionreceiver whose last segment is capitalized now emits areferencesref under its qualified name, leading::dropped. SoUsers::Create.callandUsers::Create&.callreachUsers::Create, not aBilling::Createof the same name. A relativeDeep::Op.callinsidemodule SvcreachesSvc::Deep::Op, andActiveRecord::Basenever reaches a projectBase. The kernel (ruby.rs) and wasm emit the same refs,::Foo.callincluded.Validation
__tests__/ruby-namespaced-receiver.test.ts: 5 cases, each on kernel and wasm, plus a kernel-parity case for these receiver shapes.CODEGRAPH_KERNEL_EXPECT=1): 6,991 passed, 0 failed. tsc clean.Agent-assisted: written with Claude Code.
🤖 Generated with Claude Code