[colbymchenry]

Summary

codegraph affected --filter <glob> matched its glob anywhere inside a path, so tests/**/*.py missed the tests directly inside tests/, including a changed test file itself, a changed tests/x.py.bak counted as a test under tests/*.py, and e2e/*.spec.ts matched an xe2e/ folder. The glob now has to match the whole name. A pattern with a folder in it still matches that folder at any depth, as the help text's own e2e/*.spec.ts always did; a leading / anchors it at the project root.

Root cause

The affected action in src/bin/codegraph.ts turned the glob into a regex by hand, with no anchors:

const regex = options.filter
  .replace(/[+[\]{}()^$|\\]/g, '\\$&')
  .replace(/\./g, '\\.')
  .replace(/\*\*/g, '.+')
  .replace(/\*/g, '[^/]*');
customFilter = new RegExp(regex);

• No ^/$: tests/[^/]*\.py matches inside tests/x.py.bak and other/tests/x.py, and e2e/... inside xe2e/....
• ** became .+, which needs at least one character, so tests/.+/[^/]*\.py needs a folder below tests/.
• /tests/*.py became /tests/..., which only a nested tests/ can match.

Fix

A small affectedFilterMatcher builds a picomatch matcher (an existing dependency, loaded lazily, only by this command) with dot: true and windows: false (stored paths always use /), tested against the project-relative path:

Pattern	Matches
no slash: *_test.go, test_*.py	the file name, at any depth (as before)
a slash: e2e/*.spec.ts, tests/**/*.py	the path from any folder boundary, an implicit leading **/ (depth-free, as before, but only at a folder boundary)
leading / or ./: /tests/*.py	from the project root only (new)
trailing /: tests/	everything under that folder (as before)

The whole name must match, and ** matches zero folders. A pattern picomatch rejects (an empty one) is reported as an invalid --filter before the index is opened. The --filter help text now says how each form matches.

A choice for Colby: slash patterns stay depth-free, so tests/*.py still matches other/tests/test_x.py, the way e2e/*.spec.ts in the help text has always matched apps/web/e2e/login.spec.ts. Our triage (T8) suggested root-anchoring instead, which is picomatch's default and what #1273 does, with **/e2e/*.spec.ts documented for the depth-free case. I kept today's reading so that no existing filter silently starts matching fewer tests, and added the leading / for anchoring. Switching to root-anchoring later is a one-line change in affectedFilterMatcher plus the help text.

Validation

• New __tests__/cli-affected-filter-globs.test.ts (6 tests, through the built CLI, beside cli-affected-paths.test.ts): 4 fail with main's src/bin/codegraph.ts and all pass with the fix. The other 2 pin what stays the same on purpose: file-name patterns at any depth, checks/*.py (a folder outside the test conventions), dotfiles, and a trailing-slash folder.
• cli-affected-paths and cli-affected-test-conventions pass unchanged.
• The triage fixture (math_utils.py imported by tests at several depths), main's build vs this branch's:

Query	main	fix
affected math_utils.py --filter 'tests/**/*.py'	tests/unit/deep/…, tests/unit/…	+ tests/test_math_utils.py, other/tests/test_math_utils.py
affected tests/test_math_utils.py.bak --filter 'tests/*.py'	the .bak file	nothing
affected tests/test_math_utils.py --filter 'tests/**/*.py'	nothing	tests/test_math_utils.py
--filter '/tests/*.py'	other/tests/test_math_utils.py only	tests/test_math_utils.py only
test_*.py, checks/*.py, tests/*.py on tests/.hidden.py	unchanged	unchanged

• Full suite on the pushed commit (a062778, main 8e854d1, kernel built from that main, CODEGRAPH_KERNEL_EXPECT=1, --maxWorkers=2 for memory headroom): 791 files (785 passed, 6 skipped), 9,424 tests: 9,339 passed, 0 failed, 85 skipped.

Left out

codegraph files --pattern and the codegraph_files tool's pattern use their own unanchored glob converter (globToRegex) and have the same substring behavior; they are a different surface and are not changed here.

Reimplements #1273 by @Jseca666, who found the substring matching and the missing root-level tests; this is an independent implementation (depth-free slash patterns, root anchoring with /, a trailing-slash folder, lazy picomatch) with new tests, credited in the CHANGELOG.

🤖 Generated with Claude Code