[colbymchenry]

Summary

In Python, a type argument in a class's base list no longer counts as a supertype. With class Repo(Base[User]), Repo.save() and repo.save() no longer link to User.save, and in class Mixed(Base[Optional[User]], Mixin), Mixed.save() now reaches Mixin.save.

Lands #3000 by @JosefAschauer.

Root cause

The Python branch of declaredSupertypes read every word of the base list, so class Repo(Base[User]) declared both Base and User. A call on the class, or on a receiver named after it, walks those supertypes for the method (classStrategyMethod → inheritedClassMethod). When Base has no save, it found User.save, at 0.85 for Repo.save() and 0.8 for repo.save().

What came from the contributor, and what we changed

From #3000, unchanged: the fix in name-matcher.ts, which drops bracketed type arguments, nested ones too, before reading the names; the new test file; the CHANGELOG text.

Ours:

• Two more cases in the test file: class Mixed(Base[Optional[User]], Mixin), where a type argument came ahead of a real base, and a quoted forward reference, class Forward(Base["Pair[str, User]"]), the shape sqlalchemy uses.
• The CHANGELOG bullet moved next to the other Python bullets, with the credit added.

Validation

Stage A: every changed line read, scanner clean. The only hits are RegExp.exec and the test's ../src import.

Reproduced on main with a fixture of our own: Repo.save(), repo.save(), Store.save() and Keyed.save() reach User::save, and Mixed.save() reaches User::save instead of Mixin::save.

Tests: red on main's name-matcher.ts (2 failed, 1 passed), green here (3 passed).

A/B against main, same build otherwise, kernel on:

Repo	Language	Edges on main	Removed	Added	Retargeted
psf/requests @ 3c7baaa	Python	2,976	0	0	0
pallets/flask @ 49943b5	Python	5,287	0	0	0
litestar-org/litestar @ 716f8b0	Python	42,289	0	0	0
python/mypy @ d8a43fb	Python	70,754	0	0	0
polarsource/polar server/ @ 8dd9956	Python	126,354	0	0	0
django/django @ a6a5d1e	Python	194,159	0	0	0
sqlalchemy/sqlalchemy @ 2d8e649	Python	228,407	1	0	0
expressjs/express @ 1c6f1b0	JavaScript (control)	2,296	0	0	0
gin-gonic/gin @ 0f09c3a	Go (control)	8,073	0	0	0

Controls and the two small Python repos have byte-identical full dumps.

The change is small on real code: 1 edge of 670,226. That edge is a.references(b) in sqlalchemy's relationships.py. Its local a matched a test's class a(TypedColumns), and class TypedColumns(ReadOnlyColumnCollection[str, "Column[Any]"]) then reached Column.references through the type argument. The target happens to be right, because the code narrows a with isinstance, but the path is the bug this fixes. Its twin b.references(a) two lines down has no edge in either arm. The call is now unresolved, which is better than a guess that happened to land.

Kernel parity: 43/43 on flask and requests in both arms. This doesn't touch the kernel.

Cost: sqlalchemy, median of 3 interleaved runs: 29.5 s on main, 25.7 s here. That gap is noise, so nothing measurable.

Suite: 828 files (822 passed, 6 skipped), 9,721 tests passed, 0 failed, 87 skipped, on this exact commit, kernel on, 2 workers.

Not in this PR

• fix(python): a base list wrapped over several lines is read whole #3001 rewrites the same Python line of declaredSupertypes, so it conflicts with this PR and gets rebased onto it. fix(python): a parameterized base links its class, like class Leaf(Base[str]) #2998 touches pythonBases only and merges clean. This PR depends on neither.
• A Repo.touch() with touch on only one project class still links at 0.7. That's the existing unique-name fallback, and a plain class Repo(Base) does the same.
• A base list wrapped past the three-line head window is still read in part, as fix(python): a base's type argument is no supertype, so Repo.save() is not User.save #3000 noted.

🤖 Generated with Claude Code