Repository navigation
Commit LFS rules by default with --use-lfs (0.1.2) - #4
Merged
Merged
Conversation
Keeping the rules only in .git/info/attributes left LFS pointer files in the working tree after any checkout, pull or clone. --use-lfs now commits per-extension rules to .gitattributes; --no-lfs-commit-rules restores the old local-only behaviour. Also: release via PyPI trusted publishing (OIDC), add CODEOWNERS, add keywords/classifiers/urls to pyproject.toml, bump to 0.1.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--use-lfskept its rules only in.git/info/attributesand removed them after the run. Any later checkout, pull, reset or clone then wrote LFS pointer files into the working tree, so videos failed to open as corrupt.Changes
--use-lfsnow commits per-extension rules to.gitattributesby default.--no-lfs-commit-rulesrestores the old local-only behaviour;--lfs-commit-rulesis still accepted.PYPI_API_TOKEN. A trusted publisher must be configured on PyPI (workflowrelease.yml, environmentpypi)..github/CODEOWNERS, and keywords, classifiers and URLs inpyproject.toml.--lfs-commit-ruleswithout--use-lfs.Testing
tests/test_cli.pypasses. The full suite was not run locally.