Repository navigation
Conversation
…_callable_param_contracts The signature passed in is built from the body, which generic_args has already instantiated. Instantiating its inputs again with the same args reinterpreted the impl's own parameters as indices into the trait method's args, so an impl with a lifetime parameter (impl<'a> Get for R<'a>) of a specified trait method panicked in rustc's binder. Fixes #354 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017R2xbmrztzZ35Qy7MPCymp
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354.
precompute_callable_param_contractsreceivessigfromfn_sig_with_body, which reads parameter types fromself.body.Analyzer::generic_argshas already instantiated that body. Instantiating each input withself.generic_argsagain applied the same args a second time.On the impl →
trait_item_typath this panicked in rustc's binder whenever the impl had a lifetime parameter, e.g.impl<'a> Get for R<'a>of a trait method with a spec. With a type parameter it silently rewroteTtoW<T>instead. This PR drops the second instantiation.Test pair
trait_impl_lifetime_param:passfile ICEs onmainand verifies with this change.failfile breaks theensures(result >= 0)contract in the impl and is rejected withUnsat.cargo testpasses locally (402 UI tests, with PCSat).Generated by Claude Code