Repository navigation
Addition of Databricks Plugin - #680
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Databricks plugin module, including a batch source, database connector, configuration classes, documentation, widgets, and unit tests. It also updates the database-commons module to support custom auto-commit and transaction isolation levels. The review feedback highlights several critical improvements: preventing potential NullPointerExceptions when the connection configuration or column names are null, handling unsupported transaction isolation levels gracefully instead of throwing RuntimeExceptions, and implementing actual random sampling in the getRandomQuery method using ORDER BY rand().
vikasrathee-cs
force-pushed
the
databricks-plugin-addition
branch
from
August 23, 2026 15:19
80cabb2 to
9a4d4fc
Compare
vikasrathee-cs
force-pushed
the
databricks-plugin-addition
branch
from
August 23, 2026 15:39
9a4d4fc to
e865f6d
Compare
sahusanket
reviewed
Sep 21, 2026
sahusanket
reviewed
Sep 21, 2026
sahusanket
reviewed
Sep 21, 2026
sahusanket
reviewed
Sep 21, 2026
sahusanket
reviewed
Sep 21, 2026
sahusanket
reviewed
Sep 21, 2026
sahusanket
reviewed
Sep 21, 2026
sahusanket
requested changes
Sep 21, 2026
Contributor
|
Hi, I don't think you have pushed the changes yet . |
sahusanket
reviewed
Sep 23, 2026
vikasrathee-cs
force-pushed
the
databricks-plugin-addition
branch
from
September 25, 2026 09:05
e865f6d to
7057300
Compare
vikasrathee-cs
force-pushed
the
databricks-plugin-addition
branch
from
September 25, 2026 13:18
7057300 to
de3fc24
Compare
sahusanket
reviewed
Sep 28, 2026
sahusanket
reviewed
Sep 28, 2026
sahusanket
reviewed
Sep 28, 2026
sahusanket
reviewed
Sep 28, 2026
vikasrathee-cs
force-pushed
the
databricks-plugin-addition
branch
from
October 5, 2026 11:30
de3fc24 to
b499316
Compare
sahusanket
reviewed
Oct 12, 2026
sahusanket
reviewed
Oct 12, 2026
sahusanket
approved these changes
Oct 12, 2026
sahusanket
left a comment
sahusanket
left a comment
Contributor
There was a problem hiding this comment.
Minor comments left.
Please address before merging.
vishwasvaidya-cloudsufi
force-pushed
the
databricks-plugin-addition
branch
2 times, most recently
from
October 19, 2026 07:57
06a6b70 to
19c6b89
Compare
sahusanket
approved these changes
Oct 19, 2026
sahusanket
left a comment
sahusanket
left a comment
Contributor
There was a problem hiding this comment.
Please squash commits before merging.
vishwasvaidya-cloudsufi
force-pushed
the
databricks-plugin-addition
branch
from
October 19, 2026 16:11
19c6b89 to
e31dbef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of Databricks Plugin