Repository navigation
Open deployment state read-only before upgrading writes - #7199
Draft
shreyas-goenka wants to merge 1 commit into
Draft
shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
2 times, most recently
from
October 27, 2026 17:10
910e30f to
9fde869
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 27, 2026 17:29
9fde869 to
7bbb418
Compare
shreyas-goenka
changed the base branch from
shreyas-goenka_data/stack/deployment-history-setting-unenforced
to
shreyas-goenka_data/stack/deployment-history-bind-unbind
October 27, 2026 17:29
This was referenced Oct 27, 2026
Collaborator
Integration test reportCommit: df27255
Top 6 slowest tests (at least 2 minutes):
|
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 27, 2026 23:11
7bbb418 to
336e45d
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 27, 2026 23:22
336e45d to
d792f34
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 27, 2026 23:27
d792f34 to
b86afcb
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 27, 2026 23:40
b86afcb to
7a44efa
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 27, 2026 23:54
7a44efa to
96506a6
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 28, 2026 00:07
96506a6 to
ecf5a72
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 28, 2026 00:18
ecf5a72 to
6889cbc
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 28, 2026 00:54
6889cbc to
f0df6cc
Compare
shreyas-goenka
changed the base branch from
shreyas-goenka_data/stack/deployment-history-bind-unbind
to
shreyas-goenka_data/stack/deployment-history-generate
October 28, 2026 00:54
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 28, 2026 10:06
f0df6cc to
2a6f265
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 28, 2026 10:58
2a6f265 to
21c053b
Compare
Base automatically changed from
shreyas-goenka_data/stack/deployment-history-generate
to
main
October 28, 2026 11:50
Addresses denik review comment 4387774406. Remove Open mode selection; use loaded feature markers for the resource source and UpgradeToWrite for write policy. Nil DMS metadata retains file-only compatibility checks for bind and unbind.
shreyas-goenka
force-pushed
the
shreyas-goenka_data/stack/deployment-history-open-readonly
branch
from
October 28, 2026 11:50
21c053b to
df27255
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
Open(ctx, path, withRecovery)read only the file checkpoint and recover its WAL. Remove both the mode argument andOpenDmsArgs. DMS-authoritative deployments explicitly callLoadDMSStatebefore planning; that step loads service resources and validates the cached serial against the service version. All modes enable writes throughUpgradeToWriteafter approval.Bind and unbind retain their DMS-authoritative-state checks.
Stacked on #7204.
Validation: affected unit tests plus DMS, bind/unbind, WAL recovery, saved-plan, generate, and jobs/update acceptance tests pass. Tests cover loading DMS resources and version counters, and rejecting DMS-only bind/unbind without modifying the checkpoint. Go lint reports no issues.