Repository navigation
structdiff: fix IsEqual panic on named string map keys - #7206
Merged
Merged
Conversation
equalMapStringKey asserted keys with k.Interface().(string), which panics for a defined string key type (e.g. type ScriptHook string). Use Value.String(), as diffMapStringKey already does. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: e722368
Top 6 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Oct 28, 2026
Collaborator
Integration test reportCommit: 6309da2
10 interesting tests: 10 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
structdiff.IsEqualpanicked on maps keyed by a defined string type (e.g.type ScriptHook string):equalMapStringKeyasserted keys withk.Interface().(string). It now usesValue.String(), matchingGetStructDiff, which got the same fix earlier (seeTestGetStructDiffNamedStringMapKey).This pull request and its description were written by Isaac.