Repository navigation
Store pending device code logins and add cmdio.IsInputTTY - #7234
Closed
maksim-zuev-db wants to merge 2 commits into
Closed
maksim-zuev-db wants to merge 2 commits into
maksim-zuev-db wants to merge 2 commits into
Conversation
IsPromptSupported tells whether the CLI can render a prompt, so it also depends on stderr, NO_COLOR, TERM=dumb and Git Bash. A command that reads a plain line from stdin only needs to know whether a user can type into it. Co-authored-by: Isaac <no-reply@databricks.com>
A non-interactive device code login is completed by a later CLI invocation. Entry gets a PendingLogin field that holds the device code and the user code until then, so that the device code stays in the user's token storage instead of being printed or passed on the command line. A pending entry has no token. Co-authored-by: Isaac <no-reply@databricks.com>
Member
Author
|
Merged into #7220. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #7222.
Changes
Two building blocks of the non-interactive device code login (#7220):
storage.Entrygets aPendingLoginfield that holds the device code and the user code of a device code login until a later CLI invocation completes it. A pending entry has no token. The file, keyring, and memory stores persist it.cmdio.IsInputTTYreports whether stdin is a terminal. UnlikeIsPromptSupported, it does not depend on stderr,NO_COLOR,TERM=dumb, or Git Bash, which only matter for rendering prompts.Why
The non-interactive login keeps the device code in the user's token storage, so it is never printed or passed on the command line. It runs when nobody can type into stdin, which
IsPromptSupporteddoes not tell apart. Split out of #7220 to keep that PR smaller.Tests
Unit tests for storing and looking up a pending login in each store, and for
IsInputTTY.This pull request and its description were written by Isaac.