Repository navigation
Tell AI agents to pass the device code login on to the user - #7235
Open
maksim-zuev-db wants to merge 1 commit into
Open
maksim-zuev-db wants to merge 1 commit into
maksim-zuev-db wants to merge 1 commit into
Conversation
An AI agent that runs the non-interactive device code login gets the URL and the user code, but the login must be approved by the user. When an agent is detected, the first step also prints notes that tell it to give the URL and the code to the user, not to approve the login itself, and to ask the user for the confirmation code. Agent detection does not change the flow. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 5 changed tests (limit=20, 0 not selected) 5 tests: regression=5 unreleased=0 coverage=0 failing=0
TestAccept/cmd/auth/login/device-code/non-interactive/concurrent: branch ✅ | main (d27fd75) ❌ | latest (v1.22.1) ❌main (d27fd75): latest (v1.22.1): TestAccept/cmd/auth/login/device-code/non-interactive/errors: branch ✅ | main (d27fd75) ❌ | latest (v1.22.1) ❌main (d27fd75): latest (v1.22.1): TestAccept/cmd/auth/login/device-code/non-interactive/flags: branch ✅ | main (d27fd75) ❌ | latest (v1.22.1) ❌main (d27fd75): latest (v1.22.1): TestAccept/cmd/auth/login/device-code/non-interactive/nominal: branch ✅ | main (d27fd75) ❌ | latest (v1.22.1) ❌main (d27fd75): latest (v1.22.1): 1 more failure details omitted, see the full report in the run. |
Collaborator
Integration test reportCommit: 6636d4c
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #7220.
Changes
When an AI agent is detected (
useragent.AgentProvider()), the first step of the non-interactive device code login also prints notes that tell the agent to give the URL and the code to the user, not to open the URL or approve the login itself, and to ask the user for the confirmation code. Agent detection does not change the flow.Why
The login must be approved by the user, but an agent that runs it gets the URL and the code and could try to approve it itself, or not pass it on. Split out of #7220 to keep that PR smaller.
Tests
The
device-code/non-interactive/nominalacceptance test runs both steps withAGENTset.This pull request and its description were written by Isaac.