Skip to content

Fix NVQParameters.idStringFor format string - #780

Open
tlwillke wants to merge 1 commit into
mainfrom
779-nvqparametersidstringfor-throws-missingformatargumentexception
Open

tlwillke wants to merge 1 commit into
mainfrom
779-nvqparametersidstringfor-throws-missingformatargumentexception

Conversation

@tlwillke

@tlwillke tlwillke commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Fixes #779.

NVQParameters.idStringFor passed two arguments to a three-placeholder format string ("NVQ_%s_%d_%s"), so it threw MissingFormatArgumentException. The trailing _%s is removed, so the cache key is now NVQ_<dataset>_<nSubVectors>, matching the PQ key's style.

Nothing constructs NVQParameters today, so behavior doesn't change; this removes a latent failure for when NVQ is wired up as a compressor option.

Testing: adds CompressorParametersTest, which checks the NVQ cache key.

@tlwillke tlwillke self-assigned this Nov 2, 2026
@tlwillke tlwillke added bug Something isn't working 4.1.0 Release Label labels Nov 2, 2026
@tlwillke tlwillke linked an issue Nov 2, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you rebase your branch onto the latest main for regression testing and PR submission?
  • Did you trigger regression testing via Run Bench Main and review results?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?
  • Did you add documentation for this feature to the release notes directory?

If you did not complete any of these, then please explain below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.1.0 Release Label bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVQParameters.idStringFor throws MissingFormatArgumentException

1 participant