Repository navigation
Record vocabulary phase 2's agreed design in the RFC and decisions (#752) - #881
Merged
Merged
Conversation
…del (#752) The RFC's Phase 2 section now states the agreed design: three sources of readings, the derived markers, the four-step gate and where it does not reproduce the six rules, the cue table, the reserved names, the surfacing split and the sub-phase order. decisions/vocabulary-model gains the 2026-10-23 entry (every decision with its reason and key measurement, and what was declined) and the 2026-10-24 entry (the ; change, the title batch order, the Nepali words). The Phase 4 table notes the surname span shipped as Policy(two_family_names=True). mechanisms.md gains PAIRED-SPELLINGS-PER-CHANGE, the spelling-consistency measure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
S8 already says an unambiguous credential after the name core starts the run; Ph. D. merged is one, so John Smith Ph. D. Jones reading suffix 'Ph. D.' alone is a gap phase 2e closes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Mark unshipped behavior as intended, keep the RFC's phase 3 text consistent with phase 2's (Ma. in the default, default = false), correct the agnomen gate's evidence (measured with S6's lean; count-only still to measure), the abbr and Resident counts, the declined partner wording, #872's scope, and move the 2026-10-24 data (#872's predicate, sa) out of the 2026-10-23 agreement into an entry of its own. Record that the merged split credential's run start against S8 is 2e's to state, and that the other rules amendments land with their sub-phase PRs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Put the rest of the RFC's unshipped readings in the future tense (joined and split credentials, the agnomens, Ma. in fil.toml), replace the last positional pointer with the entry's key, leave the sa decline to decisions/C8, and correct fil.toml (it exists) and #789's Open handle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #881 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 47 47
Lines 4781 4781
=======================================
Hits 4737 4737
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #752. Docs only: no parse moves except one new rules-corpus row.
Vocabulary phase 2's design was agreed on 2026-10-23, with the
;change, the title-batch order and the Nepali words decided on 2026-10-24. Sub-phases 2a and 2b are being built now, and their PRs need a committed record to cite. This PR writes that record, following docs/design/AGENTS.md's "Landing a design".Where each part lands
docs/design/vocabulary-model-rfc.md, Phase 2. It replaces "the shape that design starts from" with the agreed design:
may_be_initialkept as a flag;filsand the agnomens, and joined and split credentials;Ambiguity.alternativein 2.x,Token.readingin 3.0);Unshipped behavior is written as intended ("is to"), and every "today" claim was checked against the tree.
The RFC's Phase 3 and Phase 4 sections. Phase 3 now agrees with Phase 2:
Ma.is settled in the default, anddefault = falsegets its meaning in phase 2. The Phase 4 surname-span row notes that it shipped as the opt-inPolicy(two_family_names=True)(rules/O6, Add a Policy switch for names with two family names (#754) #875, Fix the review findings on two_family_names (#875) #878), which a pack can later switch on.decisions/vocabulary-model.md. Three new entries:
;change, shipped in Read a semicolon between post-nominals as a comma (D15) #871. The title batches go in order of lone-head breakage.buddha,siddhaandgyanigo in the default gate;guruwaits for anepack.sadecline is left to decisions/C8.Other edits to the file:
Chas. Smithread givenChas.? Abbreviated given names read as titles today #789 are updated.The measurements are dated snapshots from a throwaway spike on
638685b4, with recompute commands where a figure drifts. Each sub-phase PR re-measures on its own base.mechanisms.md. New Verification shape
PAIRED-SPELLINGS-PER-CHANGE: the spelling-consistency measure, with the trap the spike hit (comparing a family's last word as written counted 1,043 false "now apart" pairs).rules/S8. One
deviates: #827row,John Smith Ph. D. Jones→ suffixPh. D. Jones, since S8's wording already covers it. The rules corpus and snapshot are re-recorded for that one new row.AGENTS.md. One sentence: a cache keyed on files cannot see a switch set by environment variable.
Deliberately left in the gitignored spec
Readingdataclass sketch. The RFC states the split and the fields; the exact API is 2m's design.vitoxis a Declined line; it is not a word refusal.Open points recorded for later PRs
Checks
uv run pytest tests/v2/test_design_docs.py tests/v2/test_doc_citations.py tests/v2/test_rules_doc.pypasses, as does the full suite: 24,373 passed, 158 skipped, 3 xfailed.sadecline,fil.tomlexisting already, ShouldChas. Smithread givenChas.? Abbreviated given names read as titles today #789's Open handle).DE SAleftover down to S6, where the spike pointed at the count. That is left for Take sa out of the vocabulary, so Maria de Sa keeps its surname (#857) #879's follow-up.No real names from the local corpora: counts and token shapes only.
🤖 Generated with Claude Code