Repository navigation
Prune AGENTS.md of v1 internals deleted at the M11 swap - #907
Merged
Merged
Conversation
…swap The Parser section, the v1 Extension Patterns (scalar and collection Constants attributes, flag-gated post_process transforms, unknown-key warnings) and six Gotchas described code that has not existed since 2.0: parse_full_name's pipeline, the _derived_* sets, the _SetManagerAttribute/_EmptyAttributeDefaultAttribute descriptors, _join_bound_first_name, join_on_conjunctions and v1's is_suffix. Rewritten rather than dropped where the lesson still holds: the layer overview, constants=None (a TypeError since #261), the #241 assignment guard (now in Constants.__setattr__), the parse-never-mutates-config invariant, the suffix/initial veto in _vocab's names, the C pickle key, and the xfail and empty-path test advice. 26,824 -> ~25,300 words. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md still described the v1 parser and config machinery that the M11 swap deleted. A session reading it would look for
parse_full_name's pipeline, the_derived_*sets, the_SetManagerAttribute/_EmptyAttributeDefaultAttributedescriptors,_join_bound_first_name,join_on_conjunctionsor v1'sis_suffix. None of them exists innameparser/(checked by grep; the names survive only in_facade._V1_HOOKSand comments).Removed
### Parser (nameparser/parser.py)section (v1 parse flow).Constantsattribute, the unknown-keyTupleManagerwarning, and the flag-gatedpost_processtransform._join_bound_first_nameguard, thelist.index()lookup injoin_on_conjunctions, and the asymmetry inis_suffix().Rewritten where the lesson still holds
config/, the logic is the_*.pypipeline, andparser.py/config/__init__.pyare re-exports.constants=NoneraisesTypeErrorsince Remove constants=None; explicit None raises with migration hint #261. The Non-descriptor Constants set attributes accept bare-string assignment; substring 'in' silently corrupts parsing #241 non-manager assignment guard now lives inConstants.__setattr__, and the parse-never-mutates-config invariant (ParsingDoesNotMutateConfigTests) is kept._vocab(is_suffix_strict,is_suffix_lenient,is_initial).HumanName.C: the pickle-key gotcha no longer names the deleted_validate_constants.This takes the file from 26,824 to about 25,300 words. I didn't touch the length problem; moving the oversized paragraphs is a follow-up.
Test plan
uv run pytest: 31621 passed.🤖 Generated with Claude Code