Repository navigation
fix: refine mention badge layout and add missing-avatar fallback - #1160
Open
brendenchu wants to merge 1 commit into
Open
brendenchu wants to merge 1 commit into
brendenchu wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Badge presentation and avatar fallback resources/js/components/bio-text.tsx |
The badge uses baseline alignment, a narrower gap, and truncation. The avatar container provides an @ fallback that is excluded from copied bio text. The avatar overlays the fallback and is hidden on load error. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Possibly related PRs
- dev-null-sh/dev-null.sh#1156: Updates the GitHub identity field used by the same component.
Suggested reviewers: xheaven, 0z3
Merge Risk: 
Minimal · up to 1a30d
-
No blocking correctness or accessibility risks were identified in the badge changes.
Pre-merge checks: 
5
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
brendenchu
marked this pull request as ready for review
October 26, 2026 01:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub mention badges in bios and company fields had uneven horizontal padding and a text baseline offset from the surrounding prose. Tighten the badge proportions, align the username baseline with the text, and show an
@fallback when an avatar cannot load.Changes
@when an avatar fails, preserving copied mention text. Remount the image when its GitHub URL changes so a previous failure cannot hide a new avatar.The shared component renders profile bios, company fields, sidebar bios, and preview bios. No preview content, database changes, or screenshot assets are included in this code branch.
Validation
Local validation completed successfully in Docker. The local development image includes OpenSSH and a named user matching its configured UID/GID; the test environment explicitly sets the upstream repository expected by the GitHub mocks. These environment fixes are outside this application PR.
docker compose -f compose.yaml build app docker compose -f compose.yaml config --quiet docker compose -f compose.yaml run --rm --no-deps \ -e APP_ENV=testing -e DB_DATABASE=testing -e DB_URL= \ -e CACHE_STORE=array -e SESSION_DRIVER=array -e MAIL_MAILER=array \ -e INERTIA_SSR_ENABLED=false \ -e GITHUB_REPOSITORY=dev-null-sh/dev-null.sh \ -e XDEBUG_MODE=coverage app composer testcomposer test— passed, exit 0.docker compose -f compose.yaml run --rm --no-deps app bun x vp test run tests/Unit/BioText.test.tsx— 4 tests passed.docker compose -f compose.yaml run --rm --no-deps app bun x vp lint resources/js/components/bio-text.tsx— no warnings or errors.git diff --check— passed.Headless Chrome checked the same seeded guest profile before and after, in both themes at 1440×1000 and 390×1000. A baseline probe measured the first mention's offset from the prose at 0.828125px before and 0px after in all four configurations. Computed bio line-height remained 24.375px and badge height remained 21.609375px. No horizontal viewport overflow was observed. The company-row alignment causes a small, approximately 2px upward shift in following content; this is not a claim of zero layout change globally.
Visual evidence
Before/after screenshots of the same seeded guest profile, independently reviewed as media revision
capture-v1. Before:3ceaefa6745d8fa5d6376213521221b44136bd4b. After:1a30db3428d5ffec70272b040ab055d82c4d5ab4. Assets are hosted separately from the code branch at commit55a68da7775146c05fd3a4328d452003ae9af4ba.Simulated avatar failure, desktop dark: GitHub avatar requests were aborted. The image became hidden and the CSS
@remained visible without a broken-image indicator.Captured layout metrics. No recording was captured; the change concerns static badge rendering.
Device verification
Headless Google Chrome 156.0.8078.47 on macOS 27.0.1, desktop and mobile viewport emulation; no physical-device or simulator testing. Captures use fresh page loads, with a reload for the simulated avatar failure. There are no new input fields or primary actions. On-screen keyboard, notch/safe-area hardware, touch interactions, scrolling, and client-side transitions were not verified.
Independent review
Independent Codex reviewer
/root/review_badge: CODE: PASS, VISUAL: PASS for base3ceaefa6745d8fa5d6376213521221b44136bd4b→ head1a30db3428d5ffec70272b040ab055d82c4d5ab4, mediacapture-v1/55a68da7775146c05fd3a4328d452003ae9af4ba.The reviewer examined the component, all four callers, existing tests, all nine screenshots, and captured layout metrics. Review identified and resolved stale hidden-image styling on username changes by keying the image by its URL. No remaining findings within that scope.
Limitations
productionwas64ab4a65c2353ed0e633cb6c2805e4565ea58603when preparing the PR; its two intervening commits do not edit this component.Summary by CodeRabbit