Repository navigation
Conversation
SwiftLint found issuesWarnings
Errors
Generated by 🚫 Danger |
b01a580 to
fe2c427
Compare
|
Hi, any news on this PR ? |
|
Grabbed the identifiers off the simulators, in case that helps with the placeholders:
( Since Display specs off Apple's page:
Ratios come out to 233:339 and 313:445. One gotcha if you read these from the simulator instead: it reports the inner screen as The two screens have different ppi though (460 vs 430), and there's only one |
|
|
@EugenKuzn @Zandor300 could you please review and merge this? We urgently need the new device support. Thanks! |
|
@EugenKuzn thanks for the quick review! Could you also publish a new release as soon as this is merged so we can use it right away? 🙏 |
Adapt PR #507, excluding iPhone Duo and the foldability API. Replace provisional identifiers with researched hardware mappings, including both iPhone 18 Pro Max regional variants. Add Apple technical specification links, display metrics, and device mapping regression coverage. Adapted from commit fe2c427.
…#512) * Add iPhone 18 Pro and Apple Watch Series 12 and Ultra 4 support Adapt PR #507, excluding iPhone Duo and the foldability API. Replace provisional identifiers with researched hardware mappings, including both iPhone 18 Pro Max regional variants. Add Apple technical specification links, display metrics, and device mapping regression coverage. Adapted from commit fe2c427. * Consolidate new device changelog entry and list case values
fe2c427 to
2ab8367
Compare
Zandor300
changed the title
c9f43f7 to
cd5fb71
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #if os(iOS) || os(watchOS) | ||
| func testSeptember2026Devices() { | ||
| struct ExpectedDevice { |
There was a problem hiding this comment.
Types should be nested at most 1 level deepnesting Tests.swift:58 |
|
@Zandor300 @EugenKuzn could you please complete the required review, merge iPhone Duo detection, and publish a new tagged release that includes it? DeviceKit 5.9.0 still maps The current CI checks are green, but GitHub still shows If the two-display API discussion is holding this up, could basic identifier/name recognition ship first, with unverified display metrics left explicitly unknown as in this PR? We need reliable model detection even while the broader display API is being worked out. Thanks for maintaining DeviceKit! |
|
It would be valuable to have this released. |
7 participants
Add provisional
Device.iPhoneDuosupport foriPhone19,4, using the existing A20 Pro CPU case. AddisFoldable, true only for iPhone Duo and its simulator. The formerplaceholder:iPhoneDuoidentifier returns.unknown. Display metrics remain unknown (-1for diagonal and screen ratio,nilfor PPI); the image is omitted and other unconfirmed capabilities retain false/empty defaults.Fix
isSimulatorfor unknown models by checking the.simulatorenum case instead of membership inallSimulators. With the 5.9.0 source andSIMULATOR_MODEL_IDENTIFIER=iPhone19,4,Device.currentisSimulator (iPhone19,4)but previously returnedfalsefromisSimulator. Simulator detection now works even before a model is added to DeviceKit.Validation:
Device.currentwith Duo and unknown simulator identifiers. The unknown-model assertions failed before the fix and pass after it.git diff --checkpassed.mapToDevicecomplexity error (146).