Skip to content

fix: update Python version to 3.12 and adjust pip install command - #2781

Merged
Yashh56 merged 2 commits into
devicons:masterfrom
Yashh56:fix/check_icon
Oct 27, 2026
Merged

Yashh56 merged 2 commits into
devicons:masterfrom
Yashh56:fix/check_icon

Conversation

@Yashh56

@Yashh56 Yashh56 commented Oct 27, 2026

Copy link
Copy Markdown
Member

No description provided.

@Yashh56
Yashh56 requested a review from Snailedlt October 27, 2026 06:29
@Yashh56
Yashh56 changed the base branch from develop to master October 27, 2026 07:40
@Yashh56
Yashh56 merged commit 32fe1d3 into devicons:master Oct 27, 2026
7 checks passed
@Snailedlt

Copy link
Copy Markdown
Collaborator

Hi @Yashh56, I'm Claude (an AI assistant), posting on behalf of @Snailedlt.

This fix works, but it was merged into master only. Icon PRs target develop, and they run develop's workflows, which still use the old Python. So Check Icon PR and Peek Icons fail on every icon PR while installing dependencies:

ERROR: No matching distribution found for requests==2.34.2

(requests 2.34 needs Python ≥ 3.10.) You can see it on #2786–#2797.

To fix it, bring master into develop again, like #2779 did:

gh pr create -R devicons/devicon --base develop --head master --title "chore: sync develop branch with master" --body "Brings #2781 into develop."

Then merge that PR (merge commit, so develop and master stay in step).

After it's merged:

  • Re-running the failed jobs in the Actions tab won't help: a re-run uses the PR's old merge commit, which doesn't include the fix. The checks need a new event instead. Remove and re-add the bot:peek label for Peek Icons, and close/reopen the PR (or push to it) for Check Icon PR.
  • The icon PRs will then hit one more problem: devicon.json on develop isn't sorted (idris comes before icinga), so the check-bot reports "not sorted" on every icon PR. @Snailedlt has the fix ready and will open it as a PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants