Repository navigation
Correct stale comments and the Hosted Relay audit migration list - #1185
Merged
Merged
Conversation
- security-hosted.md: the Hosted Relay inspection list now names 007_independent_voice.sql, which adds the approvals' purpose column - quit.ts: cite the standalone spec's real "Quit protocol" heading - fake-client.mjs: PocketClient does send e2e frames now - relay/test/helpers.mjs, pocket.test.ts: move each doc comment back above the function it describes - pairing-walkthrough/proc.mjs: started is in start order, not newest first - preview-head.html: preview.css, not preview.ts, imports index.css
Deploying mouseterm with
|
| Latest commit: |
fc8972f
|
| Status: | ⚡️ Build in progress... |
dormouse-bot
commented
Oct 19, 2026
dormouse-bot
left a comment
dormouse-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
The migration list is still missing 006_relay_setup_token_claim.sql. It adds the claimed column on dormouse_relay_setup_tokens that S99 depends on ("a retire misses a setup token a finish claimed"), so an auditor working from this list never sees the schema behind that check. I'll push the fix below.
# Conflicts: # docs/specs/security-hosted.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment and doc corrections from tonight's sweep, with no behavior change. The one that matters most is in
docs/specs/security-hosted.md: the "Hosted Relay" paragraph lists the migrations the nightly audit inspects for its checks, and the list stopped at004_relay_enrollment_redeemed.sql. Two migrations now join it:006_relay_setup_token_claim.sqladds theclaimedcolumn ondormouse_relay_setup_tokensthat S99 depends on, and007_independent_voice.sql(from #999) adds the approvals'purposecolumn and redefines the_redeemedconstraint that the purpose-binding check relies on.The rest are comments that point readers at the wrong place:
standalone/src/quit.ts: the quit-gate comment cited a"Confirmation dialog"heading thatdocs/specs/standalone.mddoesn't have. The rule sits under "Quit protocol".remote-lib-common/test/harness/fake-client.mjs: the comment saidPocketClient"does not send these frames yet", butpocket-client.tssendst: 'e2e'frames.relay/test/helpers.mjsandhosted/server/tests/pocket.test.ts: in each, a function's doc comment was stacked above an unrelatedconst's comment, so tooling attached it to theconst. Each doc comment now sits above its function.scripts/pairing-walkthrough/proc.mjs:startedis filled withpush, so it is in start order, not "newest first".spawnedHandlesis what reverses it.lib/.storybook/preview-head.html:preview.css, whichpreview.tsimports, is what importslib/src/index.css, notpreview.tsdirectly.dor-tools-builtin/viewer/markdown.tsx: two separate imports from./document-sessionare merged into one, and a doubled blank line is removed fromdor-tools-builtin.rationale.md.node scripts/spec-lint.mjspasses. pnpm isn't available in this sandbox, so CI runs the rest.