Repository navigation
Authenticate GitHub policy checks in the security audit - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security audit in #71 ended INCONCLUSIVE because its agent had no GitHub credential for the live environment branch-policy and
mainrules checks. Unauthenticated requests hit the runner's API rate limit even though both settings were correct.Supply the existing workflow token as
GH_TOKEN, using the permissions already granted to the job. Redact that token from both the report and transcript before publication, and clarify that the auditor must fetch the live policies with pagination and retain UNVERIFIABLE on API errors.Validation:
node --test scripts/*.test.mjs, including regression coverage for token availability and redaction from both published files. The new checks failed before the fix.mainbranch and the active branch rules require pull requests and block force-pushes and deletion.git diff --check.The hosted audit remains to be validated after merge; pushing the merge commit to
mainstarts it automatically.Fixes #71.