Repository navigation
Preserve authentication errors for catch-all 401 responses - #620
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
==========================================
+ Coverage 65.33% 65.36% +0.02%
==========================================
Files 36 36
Lines 69148 69152 +4
Branches 4986 4987 +1
==========================================
+ Hits 45180 45198 +18
+ Misses 23716 23700 -16
- Partials 252 254 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AndreyVMarkelov
enabled auto-merge (squash)
October 22, 2026 15:21
cguldner
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploads that receive a 401 response with an explicit
otherauthentication-error tag currently raise Stone'sValidationError, hiding the normal authentication exception and request ID. Decode these responses asAuthError.other, tolerate new authentication-error variants and fields, and preserve the original response body onAuthError.bodyfor diagnosis. Existing two-argumentAuthErrorconstruction remains compatible.Refs #585. This fixes the SDK's error reporting; the cause of the original server rejection still needs investigation.
Validation:
pytest test/unit/ -q: 118 passed, including seven regression cases through the upload request path. These cover explicit catch-all tags, unknown variants, known errors, and missing-scope details, and verify that non-expired authentication failures are not retried._version.pyfrom formatting.Checklist
General Contributing
Is This a Code Change?
Validation
toxpass? (Full tox suite not run.)