Repository navigation
End a result whose fetch fails to convert - #712
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A conversion error during a fetch, such as invalid UTF-8 in a VARCHAR or a Python error from a datetime
conversion, left the result open, so the next statement failed with ResourceInUseException until abort(); 1.5.6
ran it. fetchnumpy and df() on invalid UTF-8 raised SystemError "returned a result with an exception set" where
fetchall raised InvalidInputException.
With this PR, a fetch that fails to convert ends its result with the error (
Result::CloseWithError, shared with theengine failure path and taking the connection's claim when it is free), so the connection is free, an open
transaction stays valid, and a later fetch from that result raises the same error; a Python exception is raised
once as itself and afterwards as InvalidInputException carrying its text.
StringConvertchecks the string itbuilds and raises the engine's invalid unicode error for a UnicodeDecodeError, any other Python error as itself.