Repository navigation
fix(template): quote Bash context working directories - #353
Open
Apeksha9389 wants to merge 1 commit into
Open
Apeksha9389 wants to merge 1 commit into
Apeksha9389 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mishushakov
enabled auto-merge (squash)
October 21, 2026 13:03
mishushakov
approved these changes
Oct 21, 2026
mishushakov
disabled auto-merge
October 21, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Bash context whose existing working-directory path contains a single quote is created with the wrong actual directory. For example, a directory named
it's workingproduces an invalidcd '.../it's working'command. The context can still report the requested cwd even thoughpwdremains in the original directory, so later relative file operations target the wrong location.Use
shlex.quote()for the Bash path instead of surrounding it with literal single quotes. Includes a template patch changeset.Validation on Python 3.12: 8 selected HTTP-level context tests pass against a local template server backed by real Jupyter Python and Bash kernels. The apostrophe regression fails on unchanged main by observing the wrong
pwd; the space-only control passes there. Added tests create and remove actual directories and contexts through the existing harness. Ruff 0.11.13 check/format pass on the changed files.The cloud sandbox suite and other language kernels were not run. This changes only Bash cwd handling.
Prepared with AI assistance; reproduced and tested locally.