Skip to content

Remove external HTTPS probes from tests - #356

Merged
matthewlouisbrockman merged 1 commit into
mainfrom
remove-external-certificate-probes
Oct 20, 2026
Merged

matthewlouisbrockman merged 1 commit into
mainfrom
remove-external-certificate-probes

Conversation

@matthewlouisbrockman

Copy link
Copy Markdown
Contributor

Removes the test that calls three hardcoded external HTTPS endpoints, along with its unused imports.

Verification: Ruff lint and format checks passed; the three remaining tests collect successfully.

@cla-bot cla-bot Bot added the cla-signed label Oct 20, 2026
@cursor

cursor Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only change that removes network-dependent coverage; no production behavior changes.

Overview
Removes the Node.js certificate test that hit three external HTTPS hosts via sandbox.commands.run and CodeInterpreter.run_code, and drops the unused json import and CodeInterpreter harness import from tests/test_certificates.py. Python and Java certificate store checks are unchanged.

Reviewed by Cursor Bugbot for commit 05f2f29. Bugbot is set up for automated code reviews on this repo. Configure here.

@matthewlouisbrockman
matthewlouisbrockman marked this pull request as ready for review October 20, 2026 22:51
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T22:52:55.239457Z 05f2f29 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/e2b-dev/code-interpreter/blob/05f2f29bb7b89c69c7d98e2067da57ee1b758fe1/tests/test_certificates.py#L84
P2 Badge Preserve offline coverage of Node's system trust selection

When NODE_OPTIONS=--use-openssl-ca stops reaching either sandbox Node processes or the JavaScript kernel—the separate propagation paths configured in template/template.py and the Jupyter service—the remaining tests still pass because they inspect only Python/OpenSSL and Java stores. Removing this entire test therefore leaves the recently added Node certificate-trust fix unprotected; replace the external probes with a deterministic local TLS fixture or assertions that both Node contexts use the configured system trust store.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment thread tests/test_certificates.py
@matthewlouisbrockman
matthewlouisbrockman merged commit 2f3f0b7 into main Oct 20, 2026
13 checks passed
@matthewlouisbrockman
matthewlouisbrockman deleted the remove-external-certificate-probes branch October 20, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants