Repository navigation
Remove external HTTPS probes from tests - #356
Conversation
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 05f2f29. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
https://github.com/e2b-dev/code-interpreter/blob/05f2f29bb7b89c69c7d98e2067da57ee1b758fe1/tests/test_certificates.py#L84
Preserve offline coverage of Node's system trust selection
When NODE_OPTIONS=--use-openssl-ca stops reaching either sandbox Node processes or the JavaScript kernel—the separate propagation paths configured in template/template.py and the Jupyter service—the remaining tests still pass because they inspect only Python/OpenSSL and Java stores. Removing this entire test therefore leaves the recently added Node certificate-trust fix unprotected; replace the external probes with a deterministic local TLS fixture or assertions that both Node contexts use the configured system trust store.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Removes the test that calls three hardcoded external HTTPS endpoints, along with its unused imports.
Verification: Ruff lint and format checks passed; the three remaining tests collect successfully.