Repository navigation
Conversation
SougandhS
force-pushed
the
FIxLaunchDial
branch
from
October 9, 2026 05:29
43bdc23 to
380f7e7
Compare
Contributor
SougandhS
force-pushed
the
FIxLaunchDial
branch
2 times, most recently
from
October 11, 2026 17:02
a94b671 to
55e562f
Compare
merks
requested changes
Oct 11, 2026
merks
left a comment
merks
left a comment
Contributor
There was a problem hiding this comment.
I’m looking on my phone. I likely can and a better job on a bigger screen.
SougandhS
force-pushed
the
FIxLaunchDial
branch
2 times, most recently
from
October 11, 2026 17:45
0ead9cb to
5a30600
Compare
SougandhS
force-pushed
the
FIxLaunchDial
branch
2 times, most recently
from
October 15, 2026 07:44
fa06f47 to
a8fa439
Compare
Contributor
Author
|
Just rebased on master 👍 .. |
SougandhS
force-pushed
the
FIxLaunchDial
branch
from
October 18, 2026 04:11
a8fa439 to
9846b57
Compare
Contributor
Author
|
Hi @merks, could you please re-check this PR ? |
merks
approved these changes
Oct 18, 2026
merks
left a comment
merks
left a comment
Contributor
There was a problem hiding this comment.
It looks okay. I haven't tested though...
Contributor
Author
|
Hi @iloveeclipse, can you have a look at this ? |
On macOS the tree selects on mouse down, and opening the modal "unsaved changes" prompt at that point corrupts the tree. Skip selection changes while the mouse is pressed and handle them on release. Fixes eclipse-jdt/eclipse.jdt.debug#909
SougandhS
force-pushed
the
FIxLaunchDial
branch
from
October 27, 2026 01:40
9846b57 to
46235aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS the tree selects on mouse down, and opening the modal "unsaved changes" prompt at that point corrupts the tree. Skip selection changes while the mouse is pressed and handle them on release.
Before :
Screen.Recording.2026-10-09.at.10.52.07.AM.mov
After :
Screen.Recording.2026-10-09.at.10.52.58.AM.mov
Fixes eclipse-jdt/eclipse.jdt.debug#909