Repository navigation
Fix unified diff final-line painting and read-only overlays - #3043
Open
tobiasmelcher wants to merge 1 commit into
Open
tobiasmelcher wants to merge 1 commit into
tobiasmelcher wants to merge 1 commit into
Conversation
Use the caret location when painting the end of a final line without a delimiter to avoid an out-of-bounds StyledText range. Make click-through mining overlays read-only while retaining text selection and copying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Painting a changed final line without a newline could throw an index-out-of-bounds exception because its end offset is outside the character range accepted by StyledText.getTextBounds. Use the caret location at that offset so the diff background and border can still be painted.
Make the click-through code-mining viewer read-only while retaining text selection and copying. Add regression coverage for final-line painting and attempts to edit the overlay.