Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #442.
Encode generated text with UTF-8
surrogateescapeso undecodable filesystem bytes survive writing activation scripts. Ordinary Unicode still uses UTF-8, byte content is unchanged, and unrelated invalid surrogates still raise an error. Add overwrite/append regressions and a Linux-only test that activates an environment in a real non-UTF-8 path.Validation on macOS, Python 3.12.14:
urllib.request.getproxiesdisabled in the test process. The normal invocation fails one existing localhost connection-refused test with HTTP 503; the unchanged base reproduces the same failure because macOS system proxy settings intercept it. Original logs are retained.nodeenv --node=system --prompt=<raw byte 0xe9>creation and bash activation preserve the raw prompt byte after this change; the original code raisesUnicodeEncodeError.flake8 --extend-ignore=E127 nodeenv.py tests setup.pyandgit diff --checkpass.This macOS filesystem rejects non-UTF-8 filenames, so the real raw-path activation test is provided for Linux CI and was not executed locally. Other Python/OS versions and download/build integration tests were not run.
AI-assisted implementation and review.